Using new ScrapedDuck generic event data#909
Open
hamster007Github wants to merge 2 commits intoKartulUdus:developfrom
Open
Using new ScrapedDuck generic event data#909hamster007Github wants to merge 2 commits intoKartulUdus:developfrom
hamster007Github wants to merge 2 commits intoKartulUdus:developfrom
Conversation
Collaborator
|
No longer required |
Contributor
Author
|
The PR is still needed / an addition. Without, the new generic data is not checked. I already changed back the url to original repo. |
Fabio1988
approved these changes
Sep 28, 2024
Contributor
|
what's the state of this? tested and working fine? :) |
Contributor
|
not working anymore - needs a fix since repo adds generic data -> null |
Contributor
Think this got fixed There is even a lot of activity in that repo and more stuff was added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using new additional generic event data to also notify about events != spotlight-hour and community day.
Description
check new
extraData->genericblock in event dataMotivation and Context
Enable PoracleJS to notify about start/end of all kind of events, which change pokemon or field-research pool. Before we only check by event type (spotlight-hour and community-day)
How Has This Been Tested?
Local debugging. Filtered event lists contain expected events.
Screenshots (if appropriate):
N/A
Types of changes
Checklist: