refactor: swap to uicons.js lib#908
Open
TurtIeSocks wants to merge 5 commits intoKartulUdus:developfrom
Open
Conversation
Collaborator
|
At a cost of deprecating support for telegram non uicons repos? |
Contributor
Author
|
I don't believe this PR deprecates any functionality. |
Fabio1988
reviewed
Aug 30, 2024
Contributor
Author
|
As discussed in Discord, this has been verified to be working with Discord and Telegram and is ready to merge. |
ReuschelCGN
approved these changes
Oct 1, 2024
Contributor
ReuschelCGN
left a comment
ReuschelCGN
left a comment
There was a problem hiding this comment.
with discord it works fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify the poracle uicons class by moving large portions of the logic to the external uicons.js lib, written by yours truly and implemented in ReactMap and other pogo tools.
Motivation and Context
This keeps our approach to uicons in sync.
How Has This Been Tested?
Currently untested.Deployed to prod and working as expected.Checklist: