Skip to content

CR#10

Open
KarolBautrel wants to merge 31 commits intofrontend/crfrom
main
Open

CR#10
KarolBautrel wants to merge 31 commits intofrontend/crfrom
main

Conversation

@KarolBautrel
Copy link
Owner

No description provided.

KarolBautrel and others added 29 commits August 3, 2022 14:10
…tProccess

Feature/payment procces comment proccess
…ing_css

Refactor/refactoring code adding css
@gitguardian
Copy link

gitguardian bot commented Aug 18, 2022

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4122488 Generic High Entropy Secret d1355f6 frontend/src/hooks/useGeolocation.js View secret
4122488 Generic High Entropy Secret 88ed69f frontend/src/hooks/useGeolocation.js View secret
4093415 Django Secret Key 5cb4510 backend/backend/settings.py View secret
4122488 Generic High Entropy Secret 5cb4510 frontend/src/hooks/useGeolocation.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

</div>
<QueryClientProvider client={queryClient}>
<SessionHandler>
<div className="App">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to mi się wydaje że zbędne w tym miejscu

import Button from "react-bootstrap/Button";

export const AlertMessage = ({ alertMessage, setAlertMessage }) => {
let { status, variant, body } = alertMessage;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const


export const AlertMessage = ({ alertMessage, setAlertMessage }) => {
let { status, variant, body } = alertMessage;
if (status) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to ogólnie jest tricky

raczej powinieneś zrobić

if (!status) return null;

return (
  <Alert ...
  

const coords = [data.latitude, data.longitude];

return (
<div className="leaflet-container" style={{ borderRadius: "150px" }}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style inline i classname jednocześnie, zdecyduj się na jedno rozwiązanie

import "./Modal.css";

const Modal = ({ children, handleCloseModal }) => {
return (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jak nie masz żadnych funkcji czy side effectów to możesz zrobić po prostu

=> (
<div>

zamiast

=> { 
 return (

import "./DishesList.css";
import Card from "react-bootstrap/Card";
export const DishesList = ({ data }) => {
return (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu ten return zbedny jak gdzies wyzej

export const DishesList = ({ data }) => {
return (
<div>
<div className="justify-content-around">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xD

<Card.Img
style={{ marginLeft: "35%" }}
variant="top"
src="holder.js/100px180"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to raczej importować jako zmienna


return (
<div>
{status === "loading" ? (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

te loadingi to wszędzie wywalić gdzieś do ifka

Delete
</Button>
) : (
<></>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

czo to

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tuta jjeszcze nie wiedzialem ze mozna robic costam? wyswietl: null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants