Api metadata #1
Open
Api metadata #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianhe8x
reviewed
Apr 17, 2019
packages/api/src/Base.ts
Outdated
| ? options.source._rpcBase._provider.clone() | ||
| : options.provider; | ||
|
|
||
| const genesisSpecToMetaDataMap = options.GenesisSpecToMetaDataMap ? options.GenesisSpecToMetaDataMap : {}; |
Collaborator
There was a problem hiding this comment.
use deconstructing to assign a default value.
Collaborator
There was a problem hiding this comment.
GenesisSpecToMetaDataMap first G should be lowercase
Collaborator
There was a problem hiding this comment.
need a better name, something like prebundles
ianhe8x
reviewed
Apr 17, 2019
packages/api/src/Base.ts
Outdated
| } | ||
|
|
||
| private init (): void { | ||
| private init (genesisSpecToMetaDataMap: {[key: string]: string}): void { |
Collaborator
There was a problem hiding this comment.
no need to change signature of init(), you can use this.options to get visit the value
Collaborator
|
can't find where you update ApiOptions |
ianhe8x
reviewed
Apr 18, 2019
packages/api/src/Base.ts
Outdated
| if (this._runtimeVersion) { | ||
| key = `${this._genesisHash}${this._runtimeVersion.specVersion}`; | ||
| } | ||
| if (key in genesisSpecToMetaDataMap) { |
Collaborator
There was a problem hiding this comment.
why use a for loop? i think you have a key already, so either it exists or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.