ci(workflow): 移除docker构建 #606
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe PR removes the Docker build workflow entirely, makes minor formatting and dispatch parameter adjustments to the release workflow, and updates a dev dependency version in the core package configuration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's Guide此 PR 移除了专用的 Docker GitHub Actions workflow，调整了 release workflow，使其在另一个仓库中触发 Docker 构建，更新了一个开发依赖的版本，并包含一些轻微的配置和风格调整。 更新后的 release workflow（在外部仓库触发 Docker 构建）的流程图flowchart TD
trigger[Tag push or release trigger]
subgraph Release_Workflow_release_yml
setupNode[Setup Node using actions_setup-node@v4\nregistry-url https://registry.npmjs.org]
setupPnpm[Setup pnpm using pnpm_action-setup@v2]
buildAndPublish[Build and publish core package]
checkCoreChanged[Check if core release is needed\nneeds.release-please.outputs.core == true]
dispatchDocker[Dispatch docker build workflow\nusing benc-uk_workflow-dispatch@v1\nrepo github.repository_owner/karin-docker\nworkflow docker.yaml]
end
trigger --> setupNode --> setupPnpm --> buildAndPublish --> checkCoreChanged
checkCoreChanged -->|core == true| dispatchDocker
checkCoreChanged -->|core != true| endNoDocker[Skip docker dispatch]
subgraph External_Docker_Repo
dockerWorkflow[docker.yaml workflow in karin-docker repo]
end
dispatchDocker --> dockerWorkflow
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your Experience打开你的 dashboard 来：
Getting HelpOriginal review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes the dedicated Docker GitHub Actions workflow, adjusts the release workflow to dispatch the Docker build in a different repository, updates a dev dependency version, and includes minor configuration/style tweaks. Flow diagram for updated release workflow dispatching Docker build externallyflowchart TD
trigger[Tag push or release trigger]
subgraph Release_Workflow_release_yml
setupNode[Setup Node using actions_setup-node@v4\nregistry-url https://registry.npmjs.org]
setupPnpm[Setup pnpm using pnpm_action-setup@v2]
buildAndPublish[Build and publish core package]
checkCoreChanged[Check if core release is needed\nneeds.release-please.outputs.core == true]
dispatchDocker[Dispatch docker build workflow\nusing benc-uk_workflow-dispatch@v1\nrepo github.repository_owner/karin-docker\nworkflow docker.yaml]
end
trigger --> setupNode --> setupPnpm --> buildAndPublish --> checkCoreChanged
checkCoreChanged -->|core == true| dispatchDocker
checkCoreChanged -->|core != true| endNoDocker[Skip docker dispatch]
subgraph External_Docker_Repo
dockerWorkflow[docker.yaml workflow in karin-docker repo]
end
dispatchDocker --> dockerWorkflow
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @shiwuliya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 尽管 PR 标题提及“移除 docker 构建”，但本次提交的实际内容主要集中在依赖项的更新和锁定文件的精细化调整上。这些更改旨在提升项目的依赖管理准确性、兼容性和稳定性，确保在不同 Linux 环境下原生模块的正确加载。 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
嗨——我已经审查了你的改动，一切看起来都很棒！
帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进之后的代码审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
这个 PR 主要通过将 Docker 构建委托给外部仓库来简化发布流程，并更新了核心开发依赖。整体来看，变更内容清晰，目的明确。依赖项 @karinjs/node-pty 的版本升级是常规操作。
我有一个关于 @karinjs/node-pty 依赖声明位置的建议，请查看具体评论。将其移至 optionalDependencies 可以更准确地反映其作为可选运行时功能的性质，并改善最终用户的体验。
其他的变更，如 pnpm-lock.yaml 的更新和 package.json 文件末尾添加换行符，都是正确且符合最佳实践的。
| }, | ||
| "devDependencies": { | ||
| "@karinjs/node-pty": "^1.1.0", | ||
| "@karinjs/node-pty": "^1.1.3", |
There was a problem hiding this comment.
考虑到 @karinjs/node-pty 是一个可选的运行时功能（在 terminalManager.ts 中有相应的缺失处理逻辑），建议将其从 devDependencies 移至 optionalDependencies。这能更清晰地表达其依赖关系，并避免在生产环境中因缺少此开发依赖而产生潜在问题，同时也能让需要此功能的用户明确地知道这是一个可选安装项。
你可以将此行删除，并在 package.json 中添加 optionalDependencies 字段：
"optionalDependencies": {
"@karinjs/node-pty": "^1.1.3"
},
|
你可以通过以下命令安装该版本： |
2 participants
Summary by Sourcery
通过将 Docker 镜像构建委托给外部仓库并更新核心开发依赖项来简化发布流程。
增强内容：
@karinjs/node-pty升级到最新兼容版本。CI：
karin-docker仓库中触发 Docker 构建工作流，而不是使用当前仓库中的 Docker 工作流。.github/workflows/docker.yaml工作流文件，并在发布工作流中统一 npm registry URL 的引号格式。Original summary in English
Summary by Sourcery
Streamline release process by delegating Docker image builds to an external repository and updating core development dependencies.
Enhancements:
CI:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.