Issue509 #521
Open
Issue509 #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, dynamic toolkits were loaded directly through the Project class using a separate code path from regular datasources. This caused duplicated logic, inconsistent behavior, and prevented adding toolkits via repository JSON alone. Experiments were also not treated as proper datasources, so they bypassed the standard loading pipeline. What changed Moved all dynamic-toolkit loading into the dataToolkit infrastructure. Dynamic toolkits are now represented as ToolkitDataSource measurement entries. Experiments from repository JSON are imported as Experiment_rawData. Unified the loading logic for static toolkits, dynamic toolkits, and experiments. Added full support for JSON-based toolkit import via the repository configuration. Updated CLI (hera-toolkit list, hera-toolkit import-json, hera-project project measurements list) to reflect the unified behavior. Result Dynamic toolkits and experiments now behave exactly like regular datasources. Everything is loaded through a single consistent datasource pipeline, simplifying the system, removing duplicated logic
…e/all). Extended project_measurements_list to support grouped filtering and added new aliases (project simulations list, project cache list). Fixed staticmethod dispatch issue and ensured consistent handling of Measurements, Simulations, and Cache entries across the CLI.
…he reviewer’s design requirements: ToolkitHome now properly inherits from abstractToolkit, relies on the automatic project-name mechanism, and uses the unified datasource interface for all toolkit registrations. Removed legacy logic, eliminated invalid projectName flows, added experiment toolkit integration, and redesigned toolkit listing to merge static, dynamic, and experiment toolkits into one consistent API. The resulting implementation is cleaner, aligned with the intended datalayer design, and prepares the system for further removal of deprecated code paths.
…eval with a direct call to experimentTK.getExperiment(), ensuring correct invocation, cleaner logic, and full alignment with the intended experiment toolkit API.
Collaborator
|
@ilayfalach There are conficts, can you please fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.