Skip to content

Conversation

@ilayfalach
Copy link
Collaborator

No description provided.

ilay added 2 commits October 16, 2025 12:32
- ToolkitHome.registerToolkit: add repositoryName in desc/query + overwrite semantics
- DataHandler_Class: robust sys.path handling for package/parent resource
- CLI (cli_toolkit_repository): require --repository; resolve classpath; print doc
- Unit tests: updated to use (repository, datasourceName); added stubs for argosDataObjects
- Notebooks: new IMS_Tutorial_Repository.ipynb and Jerusalem_Tutorial_Repository.ipynb reflecting repo-based usage"

(cherry picked from commit a9a3b75)
- ToolkitHome:
  - add `defaultRepository` support (per-project configuration)
  - `getDatasourceDocument(project, repository?, name, version?)` with fallback to default
  - BREAKING: `registerToolkit(...)` now requires `repositoryName=` (explicit)

- CLI (hera.utils.data.cli_toolkit_repository):
  - `register-datasource` now requires `--repository`
  - new `set-default-repository` to store project default
  - new `get-datasource` to fetch by (repository?, name[, version])
  - improved classpath/resource resolution and error messages

- Tests (UNIT_TEST_DYNAMIC_TOOLKITS):
  - update calls to `registerToolkit(repositoryName=...)`
  - adjust dynamic import path handling in helpers
  - add assertions for default-repository fallback

- Docs/Notebooks:
  - add `hera/doc/jupyter/datalayer/Repository_Datasource_Tutorial.ipynb`
    explaining registration, default repository, and dynamic loading

Notes:
- Existing code that calls `registerToolkit` must pass `repositoryName=`.
- `.gitignore` already excludes local venvs and checkpoints.
@yehudarav
Copy link
Collaborator

@ilayfalach The pull request has confilcts, please solve them.

@yehudarav
Copy link
Collaborator

@ilayfalach

Please fix the conflicts.

@yehudarav
Copy link
Collaborator

@ilayfalach See if it is necessary. If not close. if it is - fix confilcts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants