-
Notifications
You must be signed in to change notification settings - Fork 0
Issue457 #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ilayfalach
wants to merge
9
commits into
master
Choose a base branch
from
issue457
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue457 #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created an example to use the repository
…ignore (ignore venv & caches)
- ToolkitHome.registerToolkit: add repositoryName in desc/query + overwrite semantics - DataHandler_Class: robust sys.path handling for package/parent resource - CLI (cli_toolkit_repository): require --repository; resolve classpath; print doc - Unit tests: updated to use (repository, datasourceName); added stubs for argosDataObjects - Notebooks: new IMS_Tutorial_Repository.ipynb and Jerusalem_Tutorial_Repository.ipynb reflecting repo-based usage" (cherry picked from commit a9a3b75)
- ToolkitHome:
- add `defaultRepository` support (per-project configuration)
- `getDatasourceDocument(project, repository?, name, version?)` with fallback to default
- BREAKING: `registerToolkit(...)` now requires `repositoryName=` (explicit)
- CLI (hera.utils.data.cli_toolkit_repository):
- `register-datasource` now requires `--repository`
- new `set-default-repository` to store project default
- new `get-datasource` to fetch by (repository?, name[, version])
- improved classpath/resource resolution and error messages
- Tests (UNIT_TEST_DYNAMIC_TOOLKITS):
- update calls to `registerToolkit(repositoryName=...)`
- adjust dynamic import path handling in helpers
- add assertions for default-repository fallback
- Docs/Notebooks:
- add `hera/doc/jupyter/datalayer/Repository_Datasource_Tutorial.ipynb`
explaining registration, default repository, and dynamic loading
Notes:
- Existing code that calls `registerToolkit` must pass `repositoryName=`.
- `.gitignore` already excludes local venvs and checkpoints.
Collaborator
|
@ilayfalach The pull request has confilcts, please solve them. |
…ed_in_master=deleted, deleted_in_457=theirs, both=merge
…p master deletions)
Collaborator
|
Please fix the conflicts. |
Collaborator
|
@ilayfalach See if it is necessary. If not close. if it is - fix confilcts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.