Skip to content

update readme text with requirements & update instructions#526

Open
G-Rowell wants to merge 1 commit intoKamalisk:arkhamfrom
G-Rowell:update-readme
Open

update readme text with requirements & update instructions#526
G-Rowell wants to merge 1 commit intoKamalisk:arkhamfrom
G-Rowell:update-readme

Conversation

@G-Rowell
Copy link
Copy Markdown

@G-Rowell G-Rowell commented Aug 22, 2022

The readme fails to mention that composer version 1 is required,
add note about that and various needed dependencies

#522

Though, php bin/console app:import:std path-to-arkhamdb-json-data/ seems to be broken on my machine?

Is this outdated or is it a fault on my end?

@G-Rowell
Copy link
Copy Markdown
Author

I'm currently trying to check if the following files are needed anymore,

as all of these scripts seem to have invalid paths & reference outdated project structures?

  • cgdb.sh
  • import.sh
  • install_assets.sh
  • test.sh

@zzorba
Copy link
Copy Markdown

zzorba commented Aug 22, 2022

php bin/console app:import:std ../arkhamdb-json-data/ works for me on my local build. What's the breakage you are seeing (I sometimes run into OOM issues when importing, there is a constant you can tweak to get past them).

1 similar comment
@zzorba
Copy link
Copy Markdown

zzorba commented Aug 22, 2022

php bin/console app:import:std ../arkhamdb-json-data/ works for me on my local build. What's the breakage you are seeing (I sometimes run into OOM issues when importing, there is a constant you can tweak to get past them).

@G-Rowell
Copy link
Copy Markdown
Author

$ php bin/console app:import:std ../arkhamdb-json-data/

.....

many hundreds of line

.....

prompt asking for yes

....


01:05:52 ERROR     [console] Error thrown while running command "app:import:std '../arkhamdb-json-data/'". Message: "DateTime::__construct() expects parameter 1 to be string, object given" ["exception" => TypeError { …},"command" => "app:import:std '../arkhamdb-json-data/'","message" => "DateTime::__construct() expects parameter 1 to be string, object given"]

In ImportStdCommand.php line 563:

  Type error: DateTime::__construct() expects parameter 1 to be string, object given


app:import:std [--player] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-e|--env ENV] [--no-debug] [--] <command> <path>

@G-Rowell
Copy link
Copy Markdown
Author

Ty for your help zzorba!

It is 1am in my timezone, so I might have to sleep but will be back tmr!

@zzorba
Copy link
Copy Markdown

zzorba commented Aug 22, 2022

Smells kind of like a PHP version issue -- I'm running 7.2.34 on my local copy of this, IIRC newer versions were not working but its been at least 4 months since I resurrected my local build.

- install composer: https://getcomposer.org/download/
- clone the repo somewhere
- cd to it
- NOTE: use version 1.10.26 (the last release of version 1), using `php composer-setup.php --version=1.10.26`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR/issue/..., as I've been struggling with the same issues! ;)
Instead of --version=1.10.26, you can use --1 though I doubt they'll ever make a new Composer 1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants