Added path '/api/public/find?q=<query>' to find cads via API with the same query syntax used in cards listing#413
Open
fafranco82 wants to merge 1 commit intoKamalisk:arkhamfrom
Open
Conversation
… same query syntax used in cards listing
|
I'd love this! Was doing some API stuff today and was amazed to see this doesn't exist. |
|
I'd like to bump this PR again; this is a feature I'd absolutely love, it would make referencing the API infinitely easier and more flexible, opening up a lot of new use cases. |
Owner
|
I am not totally opposed to the idea, but the intention of the api is for all the card data to be requested once, and cached or loaded into memory, and then use whatever your application is written in to query it. (the deck builder essentially does that, and makes all card look ups client side in js) The main concern is the extra load on the server if applications start looking up every card instead of loading the data from local storage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I did in SWDestinyDB, this addition will be very helpful for 3rd party API consumers.