Redesign layout of ArkhamDB#16
Open
logan-r wants to merge 17 commits intoKamalisk:arkhamfrom
logan-r:arkham
Open
Redesign layout of ArkhamDB#16logan-r wants to merge 17 commits intoKamalisk:arkhamfrom logan-r:arkham
logan-r wants to merge 17 commits intoKamalisk:arkhamfrom
logan-r:arkham
Conversation
and make sure deck social icons get correct color
Author
|
Note: Updated so that this is still merge-able post bae41c5 |
Owner
|
So I kind of like it, but I also like how minimalist the deck builders are (nice for use at work :P) so maybe I can add some sort of theme support. When I have time I can take a proper look at it. My initial question is where did the image come from? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made some changes to the layout and look of ArkhamDB. Hopefully, you regard these as improvements - let me know what you think, and if there is anything you'd like me to change about this design!
Note: I never set up a full dev server to test this, so if the pages look all wacky it's probably because I didn't correctly link to the
/web/style.cssfile I added.Also, I've taken the liberty of adding "with contributions from logan-r" to the footer of the webpage. I'd appreciate it if you left it there, but hey, it's your project, so I'd understand if you removed it.