Add more signature/advanced/replacement codes to investigator sigs#1653
Open
zzorba wants to merge 4 commits intoKamalisk:masterfrom
Open
Add more signature/advanced/replacement codes to investigator sigs#1653zzorba wants to merge 4 commits intoKamalisk:masterfrom
zzorba wants to merge 4 commits intoKamalisk:masterfrom
Conversation
fspoettel
reviewed
Dec 6, 2025
fspoettel
reviewed
Dec 7, 2025
Contributor
fspoettel
left a comment
fspoettel
left a comment
There was a problem hiding this comment.
Very nice, this will be a big win on the app-code level. A few open questions.
| "position": 9, | ||
| "quantity": 1, | ||
| "restrictions": "investigator:11007, investigator:11008", | ||
| "signature_for": "11007", |
Contributor
There was a problem hiding this comment.
If the intent is to separate the two Agathas - which I agree with - then this should probably be "signature_for": ["11007", "11008"] or "signature_for": "11007, 11008".
This could be relevant for Chapter 2 if Replacements are ruled to affect all versions of an investigator.
| "minLength": 1, | ||
| "type": "string" | ||
| }, | ||
| "signature_for": { |
Contributor
There was a problem hiding this comment.
These should probably defined as lists from the get-go (see Agatha).
| "faction_code": "mystic", | ||
| "health": 6, | ||
| "illustrator": "Magali Villeneuve", | ||
| "investigator_id": "11007", |
Contributor
There was a problem hiding this comment.
- needs to be documented
- what do you think about
{investigator_}version_ofto keep with the relation scheme _for / _of?
zzorba
force-pushed
the
add_signature_advanced_replacement_codes
branch
from
e9bcfd8 to
12e80ee
Compare
zzorba
force-pushed
the
add_signature_advanced_replacement_codes
branch
2 times, most recently
from
88ef978 to
68d8ef7
Compare
zzorba
force-pushed
the
add_signature_advanced_replacement_codes
branch
3 times, most recently
from
eeb02fa to
80938f8
Compare
zzorba
force-pushed
the
add_signature_advanced_replacement_codes
branch
2 times, most recently
from
5be7385 to
1050ebb
Compare
Also tags the Agathas as being related, in a unique way
zzorba
force-pushed
the
add_signature_advanced_replacement_codes
branch
from
1050ebb to
99e0252
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also tags the Agathas as being related, in a unique way