added hidden true to all cards that are referenced in other cards as back_link#1628
added hidden true to all cards that are referenced in other cards as back_link#1628laiozatt wants to merge 4 commits intoKamalisk:masterfrom
Conversation
|
Fixed line indentation, please review again. Thanks! |
| "encounter_position": 10, | ||
| "faction_code": "mythos", | ||
| "flavor": "Along the shore the cloud waves break,\nThe twin suns sink behind the lake,\nThe shadows lengthen\nIn Carcosa\n - Robert W. Chambers, <u>The King in Yellow</u>", | ||
| "hidden": true, |
There was a problem hiding this comment.
With the proposed changed, now actually both sides are hidden. 😅 The problem here is that the underlying data is wrong: The locations should be unhidden and the fronts, the story cards hidden and the backs.
This is not your fault obviously, but the new changes would cause cards to no longer show up at all.
There was a problem hiding this comment.
I see. So I'm not sure how to tell if the underlying cards are wrong... Is this something that will be fixed in the near future? Should I just compare each card to their related front/backs and not set them to hidden if the other side is hidden? Wouldn't that cause future issues? Should I actually fix it by removing the hidden where it shouldn't have it?
| @@ -235,6 +235,7 @@ | |||
| "encounter_position": 2, | |||
There was a problem hiding this comment.
Same as the Dim Carcosa cards, this card is also flipped
| "encounter_position": 9, | ||
| "faction_code": "mythos", | ||
| "flavor": "…Ngranek is very difficult and barren and sinister, and there are rumours of caves near the peak wherein dwell the night-gaunts. - H. P. Lovecraft, <u>The Dream-Quest of Unknown Kadath</u>", | ||
| "hidden": true, |
There was a problem hiding this comment.
Same problem as Dim Carcosa in this file.
2 participants
Talking to Felice (author of arkham.build), we identified some cards that are referenced as back_link by other cards, and so they should have the property "hidden" set to true.
I did that change on all 38 cards where that is the case, while perserving the properties order.