[ZH] changed to zh-cn

[HarryS561]

Resolves #1418 .

Changed everything to Simplified Chinese.

[fspoettel]

@HarryS561 Is this data sourced from an "official" Simplified Chinese release, or is this a player-created translation?

[wax0714]

The simplified Chinese release and the traditional Chinese release are both official translations. Should we separate the 2 translations instead of replacing all with simplified Chinese?

[fspoettel]

Neat! There is some existing work in the arkham-cards-data repo. Can that be replaced once this PR lands? cc @zzorba for 👀 .

@wax0714, yes that would be preferable. 👍 If both translations exist in official capacity, then we should track both in here as well.

[HarryS561]

@fspoettel Here's the big image: originally only Traditional Chinese was available officially, and Simplified Chinese was added later. You may know that one or more Traditional Chinese characters usually correspond to a single Simplified Chinese character, so in theory the translation could just be a direct character-to-character replacement. However, when the official Simplified Chinese translation was added, a few keyword names were also changed (for example, "peril" was changed from "祸害" to "险境").

In this PR, I've done the character-to-character replacement with opencc, but I haven't yet updated those keyword names (maybe later, I need much help from community to know all of the changed keyword names). I wrote a comparing Python script just now, and it turns out that arkham-cards-data repo handled Simplified Chinese translation in the same way at the time. Of course, since the translation hasn't been updated in a while, its version is now less up-to-date than what's in this PR.

By the way, I also agree that Traditional Chinese should be kept, and I've already added it back in the latest commit. But I have two questions:
(1) I guess I need to update something to effectively add this Simplified Chinese translation, but I really have no idea. And I'd really appreciate help on this.
(2) Should the language code for Traditional Chinese be renamed?

[fspoettel]

@HarryS561 Thanks for the context. To further clarify:

1. Does the official translation's differences also extend to card traits?
2. In the official translation, did cards change names?
3. What is the status of the official translation? Is it up-to-date or lagging behind significantly?

For your other questions I will get back to you. For other applications that use this data (ArkhamCards, arkham.build) I could answer it, but not for ArkhamDB itself.