Skip to content

Theme icon#6

Open
mghenderson wants to merge 3 commits intoKakiharu:mainfrom
mghenderson:themeIcon
Open

Theme icon#6
mghenderson wants to merge 3 commits intoKakiharu:mainfrom
mghenderson:themeIcon

Conversation

@mghenderson
Copy link

Added the ability to specify a named icon from a plasma theme. Supporting that ability, I added some simplistic support for a config file to allow specification of the icon name, using a config file instead of a command line flag was due it being easier to implement. Although I can see it being useful to specify things like profiles/directories/etc in the future.

I can pull the .gitignore changes as that is just a personal preference thing and I know that can be annoying for a repo owner.

Copy link
Owner

@Kakiharu Kakiharu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fun idea, Here in a few days i'll try and implement it in a wider way. Might add a settings menu.

Copy link
Owner

@Kakiharu Kakiharu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to get an svg to load or does your theme use png alternatives?

@mghenderson
Copy link
Author

I was testing with svg's, but just tried it with a png from the theme and it loaded just fine.

@Kakiharu
Copy link
Owner

I could not get an svg to not be transparent.

@mghenderson
Copy link
Author

I'm unclear on what you mean.
No config file:
Default
Config file w/ tray-icon-themed-name = 'fingerprint-gui' from the breeze-dark icon pack:
Fingerprintgui
Config file w/ tray-icon-themed-name = 'xmms' from candy-icons pack:
Default - xmms

@Kakiharu
Copy link
Owner

I was exhausted when I wrote that, by transparent I meant it refuses to render an svg as the icon for me when trying to pick an icon.

@Kakiharu
Copy link
Owner

however today it is working, weird. I'll probably work on it some today.

@mghenderson
Copy link
Author

No worries, & definitely no rush. Mostly wrote this because I'm a strange fascination of ensuring all my system tray icons are themed, and the code might help someone down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants