Skip to content

refactor : RequestSettlementModal 컴포넌트 여러 개의 작은 컴포넌트로 분리 작업#33

Merged
S2UZY merged 7 commits intoKakaotechHKT:devfrom
S2UZY:refactor/request-settlement-modal
Apr 10, 2025
Merged

refactor : RequestSettlementModal 컴포넌트 여러 개의 작은 컴포넌트로 분리 작업#33
S2UZY merged 7 commits intoKakaotechHKT:devfrom
S2UZY:refactor/request-settlement-modal

Conversation

@S2UZY
Copy link
Copy Markdown
Contributor

@S2UZY S2UZY commented Apr 3, 2025

RequestSettlementModal 컴포넌트 여러 개의 작은 컴포넌트로 분리 작업 진행했습니다.
동작은 똑같아요 !

새로운 기능은 새브랜치 파서 진행하려고 합니다 -!

@S2UZY
Copy link
Copy Markdown
Contributor Author

S2UZY commented Apr 3, 2025

@Jinviz @jihostudy

Copy link
Copy Markdown
Member

@jihostudy jihostudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
하나의 컴포넌트 안에서 너무 많은 처리를 하려고 했었네요.
지금까지 왜그랬는지 모르겠는데, 분리된 컴포넌트를 하나의 컴포넌트로 처리하려 했던거 같은데 폴더로 관심사 분리해서 사용하는 방법 좋네요.

빌드 에러만 해결해주시고 다시 노티주시면 감사하겠습니다!

@S2UZY S2UZY force-pushed the refactor/request-settlement-modal branch from 4bfac72 to 21c183b Compare April 4, 2025 03:24
@S2UZY
Copy link
Copy Markdown
Contributor Author

S2UZY commented Apr 4, 2025

노아 빌드 에러 해결하고 충돌 해결 완료했습니다 -!

@jihostudy

Copy link
Copy Markdown
Member

@jihostudy jihostudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@S2UZY S2UZY merged commit 64e21da into KakaotechHKT:dev Apr 10, 2025
1 check passed
@S2UZY S2UZY deleted the refactor/request-settlement-modal branch April 10, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants