Fix the max burn time calculation for unequal-density fuel mixtures#8
Open
kamalmostafa wants to merge 1 commit intoKSPSnark:masterfrom
Open
Fix the max burn time calculation for unequal-density fuel mixtures#8kamalmostafa wants to merge 1 commit intoKSPSnark:masterfrom
kamalmostafa wants to merge 1 commit intoKSPSnark:masterfrom
Conversation
Fixes KSPSnark#7 Take fuel density into account in the max burn time calculations, in order to correct inaccurate results for mixtures of fuels with unequal densities like LH2/O. Note that stock LF/O mixture just happens to have homogeneous density, which is why this fix wasn't "needed" for (and does not change) the LF/O max burn time calculation.
kamalmostafa
force-pushed
the
fix-fuel-density
branch
from
d1e59e0 to
51eb8fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
Take fuel density into account in the max burn time calculations, in
order to correct inaccurate results for mixtures of fuels with unequal
densities like LH2/O.
Note that stock LF/O mixture just happens to have homogeneous density,
which is why this fix wasn't "needed" for (and does not change) the LF/O
max burn time calculation.