Fix #3119. Don't expose ListValue<T> lists to users #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

JonnyOThan merged 2 commits into KSP-KOS:develop from sug44:fix_collections

Feb 1, 2025

Merged

Fix #3119. Don't expose ListValue<T> lists to users #3129

Optimize by not creating list copies where possible. Revert Vessel pa…

Annotations

1 error and 10 warnings

Process completed with exit code 1.

src/kOS.Safe/Encapsulation/UniqueSetValue.cs#L48

'UniqueSetValue<T>.Clear()' hides inherited member 'CollectionValue<T, HashSet<T>>.Clear()'. Use the new keyword if hiding was intended.

src/kOS.Safe/Execution/CPU.cs#L1467

The given expression is never of the provided ('NoDelegate') type

src/kOS.Safe/Compilation/ProgramBuilder.cs#L174

Field 'ProgramBuilder.BuiltInPath.command' is never assigned to, and will always have its default value null

src/kOS.Safe/Compilation/KS/Scanner.cs#L29

Field 'Scanner.FileAndLine' is never assigned to, and will always have its default value

src/kOS/Communication/Message.cs#L55

'Message.CreateFromDump(SafeSharedObjects, Dump)' hides inherited member 'BaseMessage.CreateFromDump(SafeSharedObjects, Dump)'. Use the new keyword if hiding was intended.

src/kOS/Communication/MessageQueue.cs#L12

'MessageQueue.CreateFromDump(SafeSharedObjects, Dump)' hides inherited member 'GenericMessageQueue<Message, PlanetariumTimeProvider>.CreateFromDump(SafeSharedObjects, Dump)'. Use the new keyword if hiding was intended.

src/kOS/Suffixed/HsvaColor.cs#L45

'HsvaColor.CreateFromDump(SafeSharedObjects, Dump)' hides inherited member 'RgbaColor.CreateFromDump(SafeSharedObjects, Dump)'. Use the new keyword if hiding was intended.

src/kOS/Function/PrintList.cs#L150

Possible unintended reference comparison; to get a value comparison, cast the left hand side to type 'Object'

src/kOS/AddOns/AddonManager.cs#L14

The field 'AddonManager.shared' is never used

src/kOS/Suffixed/Widget/PopupMenu.cs#L190

Field 'PopupMenu.indexedName' is never assigned to, and will always have its default value null

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix #3119. Don't expose ListValue<T> lists to users #3129

Uh oh!

Uh oh!

Fix #3119. Don't expose ListValue<T> lists to users #3129

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...