Skip to content

Replace CT::string internals. #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maartenplieger wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Replace CT::string internals. #575

maartenplieger wants to merge 28 commits into from

Conversation

@maartenplieger
Copy link
Member

@maartenplieger maartenplieger commented Dec 8, 2025 •
edited
Loading

This work is based on #540

  • Removed CT::StackList
  • CT::string internals now work with std::string
  • splitTtoStack is now renamed split
  • Bug in CTime is fixed.
  • Reduced log statements
  • Added TRACE timings info to logs under TRACE level.
  • Removed CTStringRef
  • Set C++ standard to 20
  • Added implicit conversion between CT::string and std::string. Added conversion constructors from CT::string to std::string and vice versa.

This has no effect on the benchmark:

Running 16 requests per case, against server http://localhost:8080
WMS_TESTDATA_MANYCONTOURS
 |================| 100.0%       01x16 total=1591 ms perreq=0099 ms #######
 |================| 100.0%       02x08 total=1084 ms perreq=0067 ms #####
 |================| 100.0%       04x04 total=0638 ms perreq=0039 ms ###
 |================| 100.0%       08x02 total=0445 ms perreq=0027 ms ##
 |================| 100.0%       16x01 total=0330 ms perreq=0020 ms #
WMS_TESTDATA_NEAREST
 |================| 100.0%       01x16 total=1423 ms perreq=0088 ms #######
 |================| 100.0%       02x08 total=0977 ms perreq=0061 ms ####
 |================| 100.0%       04x04 total=0601 ms perreq=0037 ms ###
 |================| 100.0%       08x02 total=0449 ms perreq=0028 ms ##
 |================| 100.0%       16x01 total=0313 ms perreq=0019 ms #
WMS_TESTDATA_BILINEAR
 |================| 100.0%       01x16 total=1419 ms perreq=0088 ms #######
 |================| 100.0%       02x08 total=1019 ms perreq=0063 ms #####
 |================| 100.0%       04x04 total=0632 ms perreq=0039 ms ###
 |================| 100.0%       08x02 total=0487 ms perreq=0030 ms ##
 |================| 100.0%       16x01 total=0311 ms perreq=0019 ms #
WMS_TESTDATA_WMS_GETCAPABILITIES
 |================| 100.0%       01x16 total=0895 ms perreq=0055 ms ####
 |================| 100.0%       02x08 total=0571 ms perreq=0035 ms ##
 |================| 100.0%       04x04 total=0416 ms perreq=0026 ms ##
 |================| 100.0%       08x02 total=0293 ms perreq=0018 ms #
 |================| 100.0%       16x01 total=0241 ms perreq=0015 ms #
WMS_TESTDATA_WCS_GETCAPABILITIES
 |================| 100.0%       01x16 total=0873 ms perreq=0054 ms ####
 |================| 100.0%       02x08 total=0541 ms perreq=0033 ms ##
 |================| 100.0%       04x04 total=0364 ms perreq=0022 ms #
 |================| 100.0%       08x02 total=0296 ms perreq=0018 ms #
 |================| 100.0%       16x01 total=0250 ms perreq=0015 ms #
WMS_TESTDATA_WCS_DESCRIBECOVERAGE
 |================| 100.0%       01x16 total=0900 ms perreq=0056 ms ####
 |================| 100.0%       02x08 total=0567 ms perreq=0035 ms ##
 |================| 100.0%       04x04 total=0390 ms perreq=0024 ms #
 |================| 100.0%       08x02 total=0316 ms perreq=0019 ms #
 |================| 100.0%       16x01 total=0219 ms perreq=0013 ms #
WMS_TESTDATA_WCS_GETCOVERAGE_NETCDF
 |================| 100.0%       01x16 total=1162 ms perreq=0072 ms #####
 |================| 100.0%       02x08 total=0834 ms perreq=0052 ms ####
 |================| 100.0%       04x04 total=0541 ms perreq=0033 ms ##
 |================| 100.0%       08x02 total=0440 ms perreq=0027 ms ##
 |================| 100.0%       16x01 total=0317 ms perreq=0019 ms #
WMS_HD17ENSEMBLES_GETMAP_NEAREST
 |================| 100.0%       01x16 total=2133 ms perreq=0133 ms ##########
 |================| 100.0%       02x08 total=1276 ms perreq=0079 ms ######
 |================| 100.0%       04x04 total=0749 ms perreq=0046 ms ###
 |================| 100.0%       08x02 total=0520 ms perreq=0032 ms ##
 |================| 100.0%       16x01 total=0415 ms perreq=0025 ms ##
WMS_HD17ENSEMBLES_GFI_MULTIDIM_TIMESERIES
 |================| 100.0%       01x16 total=2555 ms perreq=0159 ms ############
 |================| 100.0%       02x08 total=1545 ms perreq=0096 ms #######
 |================| 100.0%       04x04 total=0950 ms perreq=0059 ms ####
 |================| 100.0%       08x02 total=0609 ms perreq=0038 ms ###
 |================| 100.0%       16x01 total=0473 ms perreq=0029 ms ##
WMS_HD17ENSEMBLES_GFI_SINGLEPOINTHTML
 |================| 100.0%       01x16 total=1404 ms perreq=0087 ms #######
 |================| 100.0%       02x08 total=1031 ms perreq=0064 ms #####
 |================| 100.0%       04x04 total=0672 ms perreq=0042 ms ###
 |================| 100.0%       08x02 total=0438 ms perreq=0027 ms ##
 |================| 100.0%       16x01 total=0348 ms perreq=0021 ms #
WMS_NC_5DIMS_GETMAP_REQUEST
 |================| 100.0%       01x16 total=2189 ms perreq=0136 ms ##########
 |================| 100.0%       02x08 total=1336 ms perreq=0083 ms ######
 |================| 100.0%       04x04 total=0782 ms perreq=0048 ms ###
 |================| 100.0%       08x02 total=0626 ms perreq=0039 ms ###
 |================| 100.0%       16x01 total=0358 ms perreq=0022 ms #
WMS_NC_5DIMS_GETCAPABILITIES_REQUEST
 |================| 100.0%       01x16 total=2405 ms perreq=0150 ms ############
 |================| 100.0%       02x08 total=1420 ms perreq=0088 ms #######
 |================| 100.0%       04x04 total=0899 ms perreq=0056 ms ####
 |================| 100.0%       08x02 total=0589 ms perreq=0036 ms ##
 |================| 100.0%       16x01 total=0426 ms perreq=0026 ms ##
WMS_NC_WIK_HARM_MANY_TIMESTEPS_GETCAPABILITIES
 |================| 100.0%       01x16 total=2407 ms perreq=0150 ms ############
 |================| 100.0%       02x08 total=1441 ms perreq=0090 ms #######
 |================| 100.0%       04x04 total=0936 ms perreq=0058 ms ####
 |================| 100.0%       08x02 total=0573 ms perreq=0035 ms ##
 |================| 100.0%       16x01 total=0509 ms perreq=0031 ms ##
WMS_NC_WIK_HARM_MANY_TIMESTEPS_GETMAP
 |================| 100.0%       01x16 total=2256 ms perreq=0141 ms ###########
 |================| 100.0%       02x08 total=1363 ms perreq=0085 ms ######
 |================| 100.0%       04x04 total=0852 ms perreq=0053 ms ####
 |================| 100.0%       08x02 total=0570 ms perreq=0035 ms ##
 |================| 100.0%       16x01 total=0432 ms perreq=0027 ms ##
WMS_NC_WIK_HARM_MANY_TIMESTEPS_GETTIMESERIES
 |================| 100.0%       01x16 total=1625 ms perreq=0101 ms ########
 |================| 100.0%       02x08 total=1127 ms perreq=0070 ms #####
 |================| 100.0%       04x04 total=0727 ms perreq=0045 ms ###
 |================| 100.0%       08x02 total=0520 ms perreq=0032 ms ##
 |================| 100.0%       16x01 total=0330 ms perreq=0020 ms #
WMS_NC_WIK_HARM_MANY_VARIABLES_GETCAPABILITIES
 |================| 100.0%       01x16 total=2854 ms perreq=0178 ms ##############
 |================| 100.0%       02x08 total=1858 ms perreq=0116 ms #########
 |================| 100.0%       04x04 total=1084 ms perreq=0067 ms #####
 |================| 100.0%       08x02 total=0767 ms perreq=0047 ms ###
 |================| 100.0%       16x01 total=0564 ms perreq=0035 ms ##
WMS_NC_WIK_HARM_MANY_VARIABLES_GETMAP
 |================| 100.0%       01x16 total=2305 ms perreq=0144 ms ###########
 |================| 100.0%       02x08 total=1436 ms perreq=0089 ms #######
 |================| 100.0%       04x04 total=0834 ms perreq=0052 ms ####
 |================| 100.0%       08x02 total=0581 ms perreq=0036 ms ##
 |================| 100.0%       16x01 total=0395 ms perreq=0024 ms #
WMS_GRIDDEDTIMESERIES_GETCAPABILITIES
 |================| 100.0%       01x16 total=0911 ms perreq=0056 ms ####
 |================| 100.0%       02x08 total=0650 ms perreq=0040 ms ###
 |================| 100.0%       04x04 total=0467 ms perreq=0029 ms ##
 |================| 100.0%       08x02 total=0364 ms perreq=0022 ms #
 |================| 100.0%       16x01 total=0291 ms perreq=0018 ms #
WMS_GRIDDEDTIMESERIES_GFI_GETTIMESERIES
 |================| 100.0%       01x16 total=2468 ms perreq=0154 ms ############
 |================| 100.0%       02x08 total=1531 ms perreq=0095 ms #######
 |================| 100.0%       04x04 total=0910 ms perreq=0056 ms ####
 |================| 100.0%       08x02 total=0645 ms perreq=0040 ms ###
 |================| 100.0%       16x01 total=0494 ms perreq=0030 ms ##
EDR_COLLECTIONS
 |================| 100.0%       01x16 total=0947 ms perreq=0059 ms ####
 |================| 100.0%       02x08 total=0673 ms perreq=0042 ms ###
 |================| 100.0%       04x04 total=0444 ms perreq=0027 ms ##
 |================| 100.0%       08x02 total=0395 ms perreq=0024 ms #
 |================| 100.0%       16x01 total=0260 ms perreq=0016 ms #
EDR_INSTANCES
 |================| 100.0%       01x16 total=1090 ms perreq=0068 ms #####
 |================| 100.0%       02x08 total=0760 ms perreq=0047 ms ###
 |================| 100.0%       04x04 total=0481 ms perreq=0030 ms ##
 |================| 100.0%       08x02 total=0376 ms perreq=0023 ms #
 |================| 100.0%       16x01 total=0318 ms perreq=0019 ms #
EDR_POSITION_WIK_HAP1_SINGLE_PARAM
 |================| 100.0%       01x16 total=2397 ms perreq=0149 ms ###########
 |================| 100.0%       02x08 total=1708 ms perreq=0106 ms ########
 |================| 100.0%       04x04 total=1152 ms perreq=0072 ms #####
 |================| 100.0%       08x02 total=0777 ms perreq=0048 ms ###
 |================| 100.0%       16x01 total=0636 ms perreq=0039 ms ###
EDR_POSITION_WIK_HAP1_MULTI_PARAM
 |================| 100.0%       01x16 total=3147 ms perreq=0196 ms ###############
 |================| 100.0%       02x08 total=2306 ms perreq=0144 ms ###########
 |================| 100.0%       04x04 total=1288 ms perreq=0080 ms ######
 |================| 100.0%       08x02 total=0949 ms perreq=0059 ms ####
 |================| 100.0%       16x01 total=0749 ms perreq=0046 ms ###
------ REPORT ------
------ PER CASE ------                                       Real    Adaguc          
Case WMS_TESTDATA_MANYCONTOURS                               4.09     12.92           seconds , numfailures: 0
Case WMS_TESTDATA_NEAREST                                    3.76     12.14           seconds , numfailures: 0
Case WMS_TESTDATA_BILINEAR                                   3.87     12.49           seconds , numfailures: 0
Case WMS_TESTDATA_WMS_GETCAPABILITIES                        2.42      8.18           seconds , numfailures: 0
Case WMS_TESTDATA_WCS_GETCAPABILITIES                        2.33      7.77           seconds , numfailures: 0
Case WMS_TESTDATA_WCS_DESCRIBECOVERAGE                       2.39      8.15           seconds , numfailures: 0
Case WMS_TESTDATA_WCS_GETCOVERAGE_NETCDF                     3.30     11.12           seconds , numfailures: 0
Case WMS_HD17ENSEMBLES_GETMAP_NEAREST                        5.10     16.29           seconds , numfailures: 0
Case WMS_HD17ENSEMBLES_GFI_MULTIDIM_TIMESERIES               6.13     19.54           seconds , numfailures: 0
Case WMS_HD17ENSEMBLES_GFI_SINGLEPOINTHTML                   3.90     12.87           seconds , numfailures: 0
Case WMS_NC_5DIMS_GETMAP_REQUEST                             5.29     16.32           seconds , numfailures: 0
Case WMS_NC_5DIMS_GETCAPABILITIES_REQUEST                    5.74     17.98           seconds , numfailures: 0
Case WMS_NC_WIK_HARM_MANY_TIMESTEPS_GETCAPABILITIES          5.87     18.63           seconds , numfailures: 0
Case WMS_NC_WIK_HARM_MANY_TIMESTEPS_GETMAP                   5.48     17.48           seconds , numfailures: 0
Case WMS_NC_WIK_HARM_MANY_TIMESTEPS_GETTIMESERIES            4.33     13.56           seconds , numfailures: 0
Case WMS_NC_WIK_HARM_MANY_VARIABLES_GETCAPABILITIES          7.13     23.47           seconds , numfailures: 0
Case WMS_NC_WIK_HARM_MANY_VARIABLES_GETMAP                   5.55     17.77           seconds , numfailures: 0
Case WMS_GRIDDEDTIMESERIES_GETCAPABILITIES                   2.69      9.22           seconds , numfailures: 0
Case WMS_GRIDDEDTIMESERIES_GFI_GETTIMESERIES                 6.05     20.10           seconds , numfailures: 0
Case EDR_COLLECTIONS                                         2.72      9.05           seconds , numfailures: 0
Case EDR_INSTANCES                                           3.03     10.35           seconds , numfailures: 0
Case EDR_POSITION_WIK_HAP1_SINGLE_PARAM                      6.67     23.62           seconds , numfailures: 0
Case EDR_POSITION_WIK_HAP1_MULTI_PARAM                       8.44     29.23           seconds , numfailures: 0
--------------------
Total benchmark took:                                      106.28    348.26           seconds

maartenplieger
maartenplieger commented Dec 8, 2025
View reviewed changes
hclasses/CTString.h
/**
* std::string containing the string
*/
std::string stdstring;
Copy link
Member Author

@maartenplieger maartenplieger Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now contains the string data for CT::string.

@maartenplieger maartenplieger changed the title DRAFT: TEST replace CT::string internals. Replace CT::string internals. Dec 17, 2025
maartenplieger
maartenplieger commented Jan 7, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maartenplieger