fix: unit tests #808
Merged
fix: unit tests #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes error
rflechtner
reviewed
Nov 26, 2024
Contributor
rflechtner
left a comment
rflechtner
left a comment
There was a problem hiding this comment.
The two rounding functions have very similar tasks, can we give them similar names?
Contributor
|
Is it me or this PR also contains changes from a different PR? I see a new line added for the |
Contributor
Author
|
Yes, I combined two smaller PRs here. The changes are intendant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3685
Some clean-ups:
Fixed-point numbers are rounded. When minting, the requested amount and the calculated collateral are rounded up, while during burning, they are rounded down. This ensures that there is always sufficient collateral during burning.
Some errors have been mapped.