chore: refactor runtimes code #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntn-x2
force-pushed
the
aa/update-benchmarks
branch
from
bc7c458 to
56d14e0
Compare
Ad96el
reviewed
Nov 15, 2024
Contributor
Ad96el
left a comment
Ad96el
left a comment
There was a problem hiding this comment.
Love it. I think splitting the runtime into smaller pieces should have be tacklet a long time ago.
I think some trait implementation for xcm are missing for the benchmarking. I would also rather change slightly the split
ntn-x2
force-pushed
the
aa/codebase-refactor-attempt-2
branch
3 times, most recently
from
6b8b609 to
984210f
Compare
ntn-x2
force-pushed
the
aa/codebase-refactor-attempt-2
branch
from
65bd6ee to
38cbf59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Fixes https://github.com/KILTprotocol/ticket/issues/3672. Built on top of #790.
Checklist