Skip to content

Conversation

@jskramer909
Copy link

Compatibility for Laravel 5.4 Framework.

Just adjusted the Service Provider to match requirements of L5.4

@bonroyage
Copy link
Collaborator

I've been working on splitting this package into two separate ones. The advantage of this would be that the illuminate/support and illuminate/container packages would no longer be a requirement if you want to use them outside of Laravel.

  1. The first being a base SSO package that is designed to work in any environment (without Laravel).
  2. The second being a Laravel wrapper for the former package designed to work with both Laravel 4 and 5 simultaneously, allowing for easier updates. Instead of ->bind(), I'm using ->singleton(), a function that has also been available since Laravel 4 (singleton() calls bind() with the $shared parameter set to true)

Hope to have it pushed by the weekend.

@NFarrington
Copy link

@bonroyage Do you still have plans to perform that split? It would be extremely useful to have this updated at some point 😃

@bonroyage
Copy link
Collaborator

Hey guys, apologies for not pushing code faster. I split up the code, version 3.* on this repo is clean PHP code (no Laravel specific stuff), then there's vatsim/sso-laravel for the Laravel specific code, which should work with both Laravel 4 and 5. You can get it by running composer require vatsim/sso-laravel 3.*. If there's an issue, please let me know here.

@abdulqadir17
Copy link

abdulqadir17 commented Nov 28, 2017

Class 'Vatsim\OAuth\OAuthServiceProvider' not found in laravel 5.3 how to add providers in config/app.php file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants