Skip to content

Conversation

@Jasonguo9019
Copy link

Changed matdbinfo.findDetMaterial to return shared pointer instead of raw pointer.

Copy link
Contributor

@brownd1978 brownd1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good Jason. I made one very minor suggestion, after you address that I will merge.

@brownd1978
Copy link
Contributor

A target for the next PR will be replacing the std::string* in
std::map< std::string*, std::shared_ptr, PtrLess > _matList;
with just std::string. There's no good reason for this to be a pointer, but you might have to change other things to get it to work.

@brownd1978
Copy link
Contributor

I see the CI is failing on Linux: it looks like you're missing a #include

@brownd1978 brownd1978 merged commit 2bd57ef into KFTrack:main Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants