-
Notifications
You must be signed in to change notification settings - Fork 3
KDT0_JinJeongMin 패스트캠퍼스 클론 코딩 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
a8ba02f
c825d35
8f79c52
a41c1a0
06c24ef
4375581
4682952
e349636
179319c
9423ab0
2f12a09
fea7234
b7e95aa
708cf8b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| .DS_Store |
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 역할에 맞게 분리하셨군요!! 잘하셨습니다 👍 |
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 다른 분 리뷰에서도 질문 남겼던게 기억이 나서 리뷰 남겨봅니다! |
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,184 @@ | ||
| /* category */ | ||
|
|
||
| .category-main-app{ | ||
| margin-top: 70px; | ||
| padding: 40px 12px; | ||
| border: 1px solid #d6d6d6; | ||
| position: relative; | ||
| } | ||
|
|
||
| .category-main-title{ | ||
| position: absolute; | ||
| top:-10px; | ||
| left: -1px; | ||
| background-color: #fff; | ||
| padding-bottom: 25px; | ||
| padding-right: 20px; | ||
| } | ||
|
|
||
| .category-menu__list{ | ||
| display: flex; | ||
| justify-content: space-around; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .category-menu__icon{ | ||
| width: 48px; | ||
| height: 48px; | ||
| background-size: cover; | ||
| transition: transform 0.2s; | ||
| } | ||
|
|
||
| .category-menu__list-item a{ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 다음부터는 클래스 네이밍도 직접 해보시길 바랍니다. |
||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .category-menu__list-item a:hover{ | ||
| color: #ed234b; | ||
| } | ||
|
|
||
| .category-menu__list-item a:hover .category-menu__icon{ | ||
| transform: translateY(-15%); | ||
| } | ||
|
|
||
| .ategory-menu__text{ | ||
| font-size: 12px; | ||
| line-height: 24px; | ||
| color: #171717; | ||
| } | ||
|
|
||
| /* category product */ | ||
|
|
||
| .category-product__container{ | ||
| margin-top: 70px; | ||
| position: relative; | ||
| } | ||
|
|
||
| .category-product__text{ | ||
| display: flex; | ||
| justify-content: space-between; | ||
| } | ||
|
|
||
| .category-product__container input[type=radio]{ | ||
| display: none; | ||
| } | ||
|
|
||
| .category-slide-btn-wrapper{ | ||
| position: absolute; | ||
| top:135px; | ||
| } | ||
|
|
||
| .category-slide-btn{ | ||
| width: 980px; | ||
| } | ||
|
|
||
| .category-slide-btn label{ | ||
| width: 32px; | ||
| height: 32px; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .category-slide-btn label:hover{ | ||
| background-color: #f2f2f2; | ||
| } | ||
|
|
||
| .category-left-label{ | ||
| position: absolute; | ||
| left:-50px; | ||
| } | ||
|
|
||
| .category-right-label{ | ||
| position: absolute; | ||
| right: -50px; | ||
| } | ||
|
|
||
| .category-left-label::before{ | ||
| content: ""; | ||
| display: block; | ||
| width: 8px; | ||
| height: 8px; | ||
| border-width: 1px; | ||
| border-color: rgb(110, 110, 115); | ||
| border-top-style: solid; | ||
| border-right-style: solid; | ||
| transform:translate3d(0, -50%, 0) rotate(-135deg); | ||
| left: 50%; | ||
| margin-top: 8px; | ||
| } | ||
|
|
||
| .category-right-label::before{ | ||
| content: ""; | ||
| display: block; | ||
| width: 8px; | ||
| height: 8px; | ||
| border-width: 1px; | ||
| border-color: rgb(110, 110, 115); | ||
| border-top-style: solid; | ||
| border-right-style: solid; | ||
| transform:translate3d(0, -50%, 0) rotate(45deg); | ||
| right: 50%; | ||
| margin-top: 8px; | ||
| } | ||
|
|
||
| .category-title{ | ||
| font-weight: 700; | ||
| font-size: 20px; | ||
| line-height: 30px; | ||
| color: #171717; | ||
| } | ||
|
|
||
| .category-link-all{ | ||
| font-weight: 700; | ||
| font-size: 16px; | ||
| line-height: 26px; | ||
| color: #757575; | ||
| text-decoration: underline; | ||
| } | ||
|
|
||
| .category-product__contents{ | ||
| margin-top: 10px; | ||
| } | ||
|
|
||
| .category-product-contents-container{ | ||
| width: 1960px; | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: flex-start; | ||
| transition: transform 1s; | ||
| transform: translateX(-0%); | ||
| } | ||
|
|
||
| .category-product__container [id="programingSlide01"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(0%);} | ||
| .category-product__container [id="programingSlide02"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(-50%);} | ||
|
|
||
| .category-product__container [id="dataSlide01"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(0%);} | ||
| .category-product__container [id="dataSlide02"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(-50%);} | ||
|
|
||
| .category-product__container [id="aiSlide01"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(0%);} | ||
| .category-product__container [id="aiSlide02"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(-50%);} | ||
|
|
||
| .category-product__container [id="designSlide01"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(0%);} | ||
| .category-product__container [id="designSlide02"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(-50%);} | ||
|
|
||
| .category-product__container [id="videoSlide01"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(0%);} | ||
| .category-product__container [id="videoSlide02"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(-50%);} | ||
|
|
||
| .category-product__container [id="illustSlide01"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(0%);} | ||
| .category-product__container [id="illustSlide02"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(-50%);} | ||
|
|
||
| .category-product__container [id="financeSlide01"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(0%);} | ||
| .category-product__container [id="financeSlide02"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(-50%);} | ||
|
|
||
| .category-product__container [id="marketingSlide01"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(0%);} | ||
| .category-product__container [id="marketingSlide02"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(-50%);} | ||
|
|
||
| .category-product__container [id="workSlide01"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(0%);} | ||
| .category-product__container [id="workSlide02"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(-50%);} | ||
|
|
||
| .category-product__container [id="businessSlide01"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(0%);} | ||
| .category-product__container [id="businessSlide02"]:checked ~ .category-product__contents .product-compose__contents .category-product-contents-container{transform: translateX(-50%);} | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. common 보다는 reset 이 더 명확한 네이밍 같습니다! |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| *{ | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
| body{ | ||
| margin: 0; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 위에서 *로 지정해줬기 때문에 필요 없어보입니다! |
||
| font-size: 1em; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1em은 불필요한 선언인 것 같아요, 왜 그럴까요?! |
||
| line-height: 1.5; | ||
| font-family: "Pretendard Variable", pretendard, -apple-system, blinkmacsystemfont, system-ui, roboto, "Helvetica Neue", "Segoe UI", "Apple SD Gothic Neo", "Noto Sans KR", "Malgun Gothic", "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", sans-serif;; | ||
| color: #171717; | ||
| } | ||
|
|
||
| a{ | ||
| color: inherit; | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| ul{ | ||
| list-style: none; | ||
| padding: 0; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이것도 맨 위에서 선언해줬기 때문에 불필요합니다! |
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README가 너무 깔끔하고, 개선사항을 스스로 정리하신 점이 좋았습니다!