-
Notifications
You must be signed in to change notification settings - Fork 0
12조 과제 제출 (정태욱, 박철민, 방미선, 백지욱) #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peacepiece7
wants to merge
1
commit into
main
Choose a base branch
from
KDT5_TEAM_12
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| module.exports = { | ||
| root: true, | ||
| env: { browser: true, es2020: true }, | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| 'plugin:react-hooks/recommended', | ||
| 'plugin:react/recommended' // self closing tag룰 적용하기 위해서 "eslint-plugin-react" 추가 설치 | ||
| ], | ||
| ignorePatterns: ['dist', '.eslintrc.cjs'], | ||
| parser: '@typescript-eslint/parser', | ||
| plugins: ['react-refresh'], | ||
| rules: { | ||
| 'react-refresh/only-export-components': ['warn', { allowConstantExport: true }], | ||
| quotes: ['error', 'single'], | ||
| 'no-console': ['error', { allow: ['warn', 'error', 'info'] }], | ||
| 'no-unused-vars': 'off', // interface에서 사용하지 않는 변수는 에러로 처리하지 않도록 설정 | ||
| '@typescript-eslint/no-unused-vars': ['error'], | ||
| 'no-multiple-empty-lines': 'error', | ||
| 'react/self-closing-comp': [ | ||
| 'error', | ||
| { | ||
| component: true, | ||
| html: true | ||
| } | ||
| ] | ||
| }, | ||
| // https://stackoverflow.com/questions/72780296/warning-react-version-not-specified-in-eslint-plugin-react-settings-while-run | ||
| settings: { | ||
| react: { | ||
| version: 'detect' | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| name: Custom issue template | ||
| about: Describe this issue template's purpose here. | ||
| title: '' | ||
| labels: enhancement | ||
| assignees: '' | ||
| --- | ||
|
|
||
| # 어떤 목적으로 이슈를 발행했는지 작성합니다. | ||
|
|
||
| e.g ) 문서작업, 스타일링, 배포 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| --- | ||
| name: Feature request | ||
| about: Suggest an idea for this project | ||
| title: '' | ||
| labels: to do | ||
| assignees: '' | ||
| --- | ||
|
|
||
| <details> | ||
|
|
||
| <summary>Feature request rules</summary> | ||
|
|
||
| - 기본적으로 이슈를 작성하는 사람이 Assignee입니다. | ||
|
|
||
| - Labels로 진행 상황 표기합니다. (to do, in progress, done 셋 중 하나는 반드시 필요) | ||
|
|
||
| - Assignees를 배정합니다. | ||
|
|
||
| - Branch는 `Feature/<이슈번호>-<기능>`으로 작성합니다. | ||
|
|
||
| - `YOLO Wallet` Project를 선택합니다. | ||
|
|
||
| </details> | ||
|
|
||
| # 기능 | ||
|
|
||
| # 적용되는 페이지 | ||
|
|
||
| # 추가 설명 | ||
|
|
||
| # 예상 시작일 | ||
|
|
||
| # 예상 완료일 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| ``` | ||
| PR 예시입니다. | ||
|
|
||
| PR을 등록할 때 해당 코드 블럭은 삭제해주세요. | ||
|
|
||
| # 요약 | ||
|
|
||
| 프로파일 컴포넌트 재사용성을 올리기 위한 리팩터링 | ||
|
|
||
| # 주요 키워드 | ||
|
|
||
| dayjs 설치 | ||
|
|
||
| /src/utils/profile.ts에 이미지 경로를 동적으로 생성하는 함수 구현 | ||
|
|
||
| /src/component/ui/profile.tsx에 뭔가 멋진 기능 구현 | ||
|
|
||
| # 추가 설명 (있을 경우만) | ||
|
|
||
| 뭔가 멋진 기능은 아래 사진처럼 프로파일 이미지가 360도 움직입니다. | ||
|
|
||
| |------| | ||
| | 사진 | | ||
| |------| | ||
|
|
||
| # 참고 | ||
|
|
||
| https//reactrouter.com/web/guides/quick-start | ||
|
|
||
| ``` | ||
|
|
||
| # 요약 | ||
|
|
||
| # 주요 키워드 | ||
|
|
||
| # 참고 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: git push into another repo to deploy to vercel | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| container: pandoc/latex | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Install mustache (to update the date) | ||
| run: apk add ruby && gem install mustache | ||
| - name: creates output | ||
| run: sh ./build.sh | ||
| - name: Pushes to another repository | ||
| id: push_directory | ||
| uses: cpina/github-action-push-to-another-repository@main | ||
| env: | ||
| API_TOKEN_GITHUB: ${{ secrets.VERCEL_DEPLOY_TOKEN }} | ||
| with: | ||
| source-directory: 'output' | ||
| destination-github-username: peacepiece7 | ||
| destination-repository-name: scheduler-front-indi | ||
| user-email: peacepiece7@naver.com | ||
| commit-message: ${{ github.event.commits[0].message }} | ||
| target-branch: main | ||
| - name: Test get variable exported by push-to-another-repository | ||
| run: echo $DESTINATION_CLONED_DIRECTORY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| pnpm-debug.log* | ||
| lerna-debug.log* | ||
|
|
||
| node_modules | ||
| *.local | ||
| dist | ||
| build | ||
|
|
||
| # Editor directories and files | ||
| .idea | ||
| .DS_Store | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
||
| npx lint-staged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "printWidth": 100, | ||
| "tabWidth": 2, | ||
| "semi": false, | ||
| "singleQuote": true, | ||
| "jsxSingleQuote": true, | ||
| "trailingComma": "none", | ||
| "bracketSpacing": true, | ||
| "arrowParens": "always", | ||
| "quoteProps": "as-needed" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| { | ||
| // scope 속성 주의! | ||
| "Print to console log": { | ||
| "prefix": "log", | ||
| "body": ["console.log($0)"], | ||
| "description": "Log output to console", | ||
| "scope": "javascript, typescript, javascriptreact, typescriptreact" | ||
| }, | ||
| "Print to console error": { | ||
| "prefix": "elog", | ||
| "body": ["console.error($0)"], | ||
| "description": "Log output to console", | ||
| "scope": "javascript, typescript, javascriptreact, typescriptreact" | ||
| }, | ||
| "Throw new Error": { | ||
| "prefix": "tne", | ||
| "body": ["throw new Error($0)"], | ||
| "scope": "javascript, typescript, javascriptreact, typescriptreact" | ||
| }, | ||
| "ES6 import from ": { | ||
| "prefix": "imf", | ||
| "body": ["import $0 from '$1'"], | ||
| "scope": "javascript, typescript, javascriptreact, typescriptreact" | ||
| }, | ||
| "Try Catch Scope": { | ||
| "prefix": "tc", | ||
| "body": "try {\n $0\n} catch (err) {\n throw new Error(err)\n}", | ||
| "scope": "javascript, typescript, javascriptreact, typescriptreact" | ||
| }, | ||
| "reactFunction": { | ||
| "prefix": "rfc", | ||
| "body": "import React from 'react';\n\nexport default function ${1:${TM_FILENAME_BASE}}() {\n\treturn (\n\t\t<div>\n\t\t\t\n\t\t</div>\n\t);\n}\n\n", | ||
| "description": "Creates a React Function component", | ||
| "scope": "javascriptreact, typescriptreact" | ||
| }, | ||
| "reactStatelessImplicitReturn": { | ||
| "prefix": "rsi", | ||
| "body": "import React from 'react';\n\nexport const ${1:${TM_FILENAME_BASE}} = (props) => {\n\t\t\t$0\n\t};", | ||
| "description": "Creates a React Function component", | ||
| "scope": "javascriptreact, typescriptreact" | ||
| }, | ||
| // postcss 에시입니다. 고쳐쓰세요! | ||
| "Import Module CSS": { | ||
| "prefix": "si", | ||
| "body": ["import styles from './$TM_FILENAME_BASE.module.css'"], | ||
| "description": "Import PostCSS", | ||
| "scope": "javascriptreact, typescriptreact" | ||
| }, | ||
| "ClassName": { | ||
| "prefix": "cn", | ||
| "body": ["className={styles.$0}"], | ||
| "description": "Adding className", | ||
| "scope": "javascriptreact, typescriptreact" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,8 @@ | ||||||||||||||||
| { | ||||||||||||||||
| "eslint.validate": ["javascript", "typescript", "typescriptreact", "javascriptreact"], | ||||||||||||||||
| "editor.codeActionsOnSave": { | ||||||||||||||||
| "source.fixAll.eslint": true // 저장할 때마다 eslint가 자동으로 코드를 고쳐줍니다. | ||||||||||||||||
| }, | ||||||||||||||||
|
Comment on lines
+3
to
+5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
이렇게 세팅해두면, 저장할 때 import도 같이 정렬해줍니다.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 와 감사합니다. 이런 정보는 찾기가 너무 힘든 것 같아요. |
||||||||||||||||
| "javascript.autoClosingTags": true, // 닫히는 태그가 자동으로 생성됩니다. | ||||||||||||||||
| "typescript.autoClosingTags": true | ||||||||||||||||
| } | ||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.