-
Notifications
You must be signed in to change notification settings - Fork 0
차동민 과제 제출 (re) #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cdm1263
wants to merge
21
commits into
KDT1-FE:main
Choose a base branch
from
cdm1263:KDT5_ChaDongMin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
차동민 과제 제출 (re) #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎬 영화 검색
영화 검색 배포 사이트
❗ 필수
❔ 선택
과제 수행 내용
컴포넌트 구조
App
MovieInfo
About
부족했던 점
MovieList를App의 하위 경로로 설정하는 과정에서Outlet컴포넌트와 props를 동시에 사용했는데 오류가 발생해 하위경로로 설정하지 못한 점MovieList가 렌더링 된 화면도 루트 경로인게 되므로 처음 화면으로 돌아가려면 새로고침을 해야하는 점App내에fetch함수가 있음에도MovieInfo내에도 별도의fetch함수를 중복 작성한 점MovieSearch의select를 분리하려 했으나 Props Drilling으로 인해 데이터 관리가 복잡해지는 문제로 못한 점Top컴포넌트들이 대부분 비슷하게 생겼음에도 여러개로 나누어 관리하는 점