Kdt5 kim sae yeon #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangheon-kim
left a comment
sangheon-kim
left a comment
There was a problem hiding this comment.
부족한점 코멘트 드렸습니다.
node_modules... .gitignore처리 부탁드립니다.
| </Routes> | ||
| </BrowserRouter> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Layout으로 만들어서 Outlet을 사용하면 더좋았을 것 같아요.
| </div> | ||
| </div> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
node_modules.... .gitignore처리 부탁드립니다.
| <select name="years" id="" className="years"> | ||
| <option value="all">All Years</option> | ||
| <option value="1985">1985</option> | ||
| <option value="1986">1986</option> |
movie/src/pages/detail/Detail.jsx
Outdated
| } | ||
| fetchData(); | ||
| }, [id]); | ||
| console.log("movie:", movie); |
|
|
||
| useEffect(() => { | ||
| async function fetchData() { | ||
| const res = await fetch( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.