과제제출합니다 #57
Open
과제제출합니다 #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const target = useRef(null) | ||
|
|
||
| return <></> | ||
| } |
| //<NavLink to={`/movies/${movie.imdbID}`}></NavLink> | ||
|
|
||
| export default MovieList | ||
| //props 사용하기 |
There was a problem hiding this comment.
movies가 안들어올 수도 있다는 가정하에 옵셔널 처리도 안되어있어서 런타임 에러날 것 같아요
| type="text" | ||
| value={props.value} | ||
| onKeyDown={e => { | ||
| if (e.keyCode === 13) props.setSearchValue(e.target.value) |
There was a problem hiding this comment.
onKeyDown을 쓰지말고
Form 태그로 감싸서onSubmit으로 받으면 되지않나요?
| import React from 'react' | ||
| import ReactDOM from 'react-dom/client' | ||
| import { RouterProvider } from 'react-router-dom' | ||
| import router from '~/routes' |
| const [searchValue, setSearchValue] = useState('') | ||
| const [show, hide] = useState({ display: 'block' }) | ||
|
|
||
| const getMovieRequest = async (searchValue, page = 1) => { |
| } | ||
|
|
||
| useEffect(() => { | ||
| getMovieRequest(searchValue) |
| const json = await res.json() | ||
| console.log(json) | ||
|
|
||
| if (json.Response === 'True') { |
There was a problem hiding this comment.
흠... Response 타입을 스트링으로 내려준게 의아하네요
fetch 자체적으로 감지할 수 있는게 있을건데요
| <h3>Genre</h3> | ||
| <p>{movieInfo.Genre}</p> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
어느것 하나 옵셔널체이닝으로 예외처리가 안되어있네요 API에러나면 클라이언트 뻗을 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
과제제출합니다