Merged
Conversation
- Skip .gitignore modification when --output-dir is outside the repo root (fixes crash on read-only repos used by sandboxed agents) - Skip .gitignore modification when .gitignore is a symlink (prevents overwriting symlink target) - Add agent/CI example to --help: smoosh --no-interactive --json . - Add 3 new bats tests covering all changes Signed-off-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
…TEMP - Change README and install.sh curl URLs from v1.0.0 to main branch (install.sh resolves latest version at runtime; pinning the URL to a tag caused stale installs) - Add SHA256 checksum verification to README manual install method - Document install.sh env vars (SMOOSH_VERSION, SMOOSH_NO_CONFIRM, etc.) - Add sudo elevation warning before fallback in install.sh - Use $RUNNER_TEMP instead of /tmp in release.yml - Fix shfmt formatting in install.sh Signed-off-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
- Add navigation table of contents at the top - Add uninstall section covering Homebrew and manual methods, with shadow binary warning - Add "Agents and CI pipelines" section with recommended flags, JSON schema example, and pre-flight pattern - Add --no-color to configuration reference table - Document colour env var precedence (NO_COLOR, FORCE_COLOR, CLICOLOR) Signed-off-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
Signed-off-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
Signed-off-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
The include-hidden-md golden file expected a .gitignore entry that was only created because of the B1 bug (ensure_output_dir fell through to modify .gitignore when --output-dir was external). With the fix, the .gitignore is correctly left untouched, so the golden file no longer includes it. Signed-off-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignorecrash on read-only repos with external--output-dir.gitignoreguard$RUNNER_TEMPin release workflow--helpoutputTest plan