Skip to content

Conversation

@cedrickcooke
Copy link
Contributor

No description provided.

@cedrickcooke cedrickcooke requested a review from a team as a code owner November 17, 2025 18:48
@cedrickcooke cedrickcooke added the maintenance General maintenance that doesn't effect the public API. label Nov 17, 2025
Copy link
Member

@twyatt twyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't applyDefaultHierarchyTemplate only needed if you customize the hierarchy? Being that you've simplified it down to this very basic form, I don't think there is any customization, so we can omit applyDefaultHierarchyTemplate?

@github-actions
Copy link

Test Results

 75 files   75 suites   10s ⏱️
458 tests 447 ✅ 11 💤 0 ❌
475 runs  459 ✅ 16 💤 0 ❌

Results for commit dfcedce.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.79%. Comparing base (90f501c) to head (dfcedce).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   69.79%   69.79%           
=======================================
  Files           9        9           
  Lines          96       96           
  Branches        5        5           
=======================================
  Hits           67       67           
  Misses         26       26           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cedrickcooke
Copy link
Contributor Author

Isn't applyDefaultHierarchyTemplate only needed if you customize the hierarchy? Being that you've simplified it down to this very basic form, I don't think there is any customization, so we can omit applyDefaultHierarchyTemplate?

Yes technically, but I really think this setting should be, well, a default. I don't want future work that decides to make something like a notJsMain have to scratch there head about why something else broke.

@cedrickcooke cedrickcooke merged commit 482b3d5 into main Nov 18, 2025
3 checks passed
@cedrickcooke cedrickcooke deleted the cedrickc/wasm-support branch November 18, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance General maintenance that doesn't effect the public API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants