Skip to content

Fix compile-time warnings and enable warn-as-error #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cedrickcooke merged 6 commits into from
Dec 16, 2025
Merged

Fix compile-time warnings and enable warn-as-error #546

cedrickcooke merged 6 commits into from
Dec 16, 2025

Conversation

@cedrickcooke
Copy link
Collaborator

@cedrickcooke cedrickcooke commented Dec 15, 2025

This would be maintenance, but removal of the Shape interface (that was causing deprecation warnings) upgraded it

@cedrickcooke cedrickcooke added the major Changes that should bump the MAJOR version number label Dec 15, 2025
@cedrickcooke cedrickcooke requested a review from a team as a code owner December 15, 2025 23:31
sdonn3
sdonn3 reviewed Dec 16, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

Test Results

72 tests  ±0   72 ✅ ±0   2s ⏱️ -1s
13 suites ±0    0 💤 ±0 
13 files   ±0    0 ❌ ±0 

Results for commit 9c231af. ± Comparison against base commit 0f8ec8d.

♻️ This comment has been updated with latest results.

@cedrickcooke cedrickcooke enabled auto-merge (squash) December 16, 2025 18:40
@cedrickcooke cedrickcooke merged commit b8c25e3 into main Dec 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twyatt twyatt twyatt approved these changes

@sdonn3 sdonn3 sdonn3 approved these changes

Assignees

No one assigned

Labels

major Changes that should bump the MAJOR version number

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cedrickcooke @twyatt @sdonn3