Selection.order optimizations
#542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twyatt
approved these changes
Dec 16, 2025
Co-authored-by: Travis Wyatt <travis@juul.com>
davertay-j
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Selection.orderalgorithm which had exponential complexity for no good reason.In the below video, top is before this PR and bottom is after. Uses the desktop sample app, but with the number of elements in the sine wave cranked up.
speed-differential.mp4
Briefly toyed with a direct port of D3's order function. Doing so exactly matched its output orderings, which this implementation doesn't, but both increased complexity and decreased runtime speed.