Skip to content

Remove unused methods #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frank-connolly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused methods #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 15 additions & 31 deletions src/main/java/org/justjava/gymcore/service/BookingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ public class BookingService {

private final BookingRepository bookingRepository;
private final UserRepository userRepository;
private final GymClassRepository gymClassRepository;
private final WaitlistRepository waitlistRepository;

public ResponseEntity<?> createBooking(Booking booking) throws BadRequestException {
Expand Down Expand Up @@ -62,13 +61,6 @@ private ResponseEntity<?> addToWaitlist(User user, GymClass gymClass) {
return new ResponseEntity<>(new ResponseDetail("GymClass is full. You are now on the waitlist."), HttpStatus.OK);
}

private boolean checkTimePeriodForTrainer(Booking booking) {
LocalDateTime bookingStartTime = booking.getGymClass().getScheduledAt();
LocalDateTime bookingEndTime = booking.getGymClass().getScheduleEnd();
boolean isTrainerAvailable = this.gymClassRepository.existsByUserIdAndBookingTimePeriod(booking.getGymClass().getTrainer().getId(), bookingStartTime, bookingEndTime);
return isTrainerAvailable;
}

private void validateGymClassTimePeriod(Booking booking) throws BadRequestException {
if (booking.getGymClass().getScheduledAt().isAfter(booking.getGymClass().getScheduleEnd()))
throw new BadRequestException("Time period is not valid.");
Expand All @@ -84,26 +76,19 @@ private void validateUsers(Booking booking) throws BadRequestException {
throw new BadRequestException("Member can not be found");
}

private void createGymClass(Booking booking) {
GymClass gymClass = new GymClass(booking.getGymClass().getTitle(), booking.getGymClass().getDescription(),
booking.getGymClass().getScheduledAt(), booking.getGymClass().getScheduleEnd(),
booking.getGymClass().getCapacity(), booking.getGymClass().getTrainer());
booking.setGymClass(gymClassRepository.save(gymClass));
public Optional<Booking> getBooking (Long id){
return bookingRepository.findById(id);
}

public Optional<Booking> getBooking (Long id){
return bookingRepository.findById(id);
}

public List<Booking> getAllBookings () {
return bookingRepository.findAll();
}
public List<Booking> getAllBookings () {
return bookingRepository.findAll();
}

public Booking updateBooking (Long id, Booking bookingDetails){
checkIfBookingExists(id);
bookingDetails.setId(id);
return bookingRepository.save(bookingDetails);
}
public Booking updateBooking (Long id, Booking bookingDetails){
checkIfBookingExists(id);
bookingDetails.setId(id);
return bookingRepository.save(bookingDetails);
}

private boolean isClassFull(GymClass gymClass) {
long confirmedBookings = bookingRepository.countByGymClassId(gymClass.getId());
Expand Down Expand Up @@ -132,11 +117,10 @@ private void promoteWaitlistedUser(GymClass gymClass) {
}
}


private void checkIfBookingExists (Long id){
if (!bookingRepository.existsById(id)) {
log.warn("Cannot proceed - Booking ID {} not found", id);
throw new IllegalArgumentException("Booking not found");
}
private void checkIfBookingExists (Long id){
if (!bookingRepository.existsById(id)) {
log.warn("Cannot proceed - Booking ID {} not found", id);
throw new IllegalArgumentException("Booking not found");
}
}
}