Skip to content

Conversation

@frank-connolly
Copy link
Collaborator

@frank-connolly frank-connolly commented Feb 8, 2025

The tests run here use the H2 in-memory DB rather than the PostgresDB to speed it up.
We can switch to Postgres later if we feel a closer reflection of production would be better

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2025

@frank-connolly frank-connolly marked this pull request as ready for review February 8, 2025 23:53
@frank-connolly frank-connolly force-pushed the feat/add-tests-to-ci-flow branch from 4008675 to 5fd7026 Compare February 8, 2025 23:57
Copy link
Collaborator

@ozkanpakdil ozkanpakdil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frank-connolly
Copy link
Collaborator Author

LGTM

@ozkanpakdil Any reason why I'm not seeing the test coverage output to the PR here? Did I break something?

Copy link
Collaborator

@madzimai madzimai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frank-connolly ,Please resolve the conflicts on
.github/workflows/CI.yml

@ozkanpakdil
Copy link
Collaborator

ozkanpakdil commented Feb 10, 2025

LGTM

@ozkanpakdil Any reason why I'm not seeing the test coverage output to the PR here? Did I break something?

@frank-connolly
the xml is not generated. if you check other build artifacts there is jacoco xml which is not generated with your PR, not sure why.

you can test manually in your local, by running the commands and check under build folder

@frank-connolly
Copy link
Collaborator Author

LGTM

@ozkanpakdil Any reason why I'm not seeing the test coverage output to the PR here? Did I break something?

@frank-connolly the xml is not generated. if you check other build artifacts there is jacoco xml which is not generated with your PR, not sure why.

you can test manually in your local, by running the commands and check under build folder

I'll investigate it when I get a chance - thanks!

Copy link
Collaborator

@ArmanRuhit ArmanRuhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't setup-java@v1 an old version?

@frank-connolly
Copy link
Collaborator Author

Isn't setup-java@v1 an old version?

Could be yes! This isn't blocking anything and I'll check it out when I get a chance. Thanks!

@frank-connolly
Copy link
Collaborator Author

Revisiting this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops Infrastructure related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As a dev I want all tests to run on the branch when I push code to it

5 participants