-
Notifications
You must be signed in to change notification settings - Fork 3
GH-30 Add tests to CI #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
4008675 to
5fd7026
Compare
ozkanpakdil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ozkanpakdil Any reason why I'm not seeing the test coverage output to the PR here? Did I break something? |
madzimai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frank-connolly ,Please resolve the conflicts on
.github/workflows/CI.yml
@frank-connolly you can test manually in your local, by running the commands and check under build folder |
I'll investigate it when I get a chance - thanks! |
ArmanRuhit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't setup-java@v1 an old version?
Could be yes! This isn't blocking anything and I'll check it out when I get a chance. Thanks! |
|
Revisiting this soon. |



The tests run here use the H2 in-memory DB rather than the PostgresDB to speed it up.
We can switch to Postgres later if we feel a closer reflection of production would be better