-
Notifications
You must be signed in to change notification settings - Fork 0
Tap counter #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Tap counter #1
Conversation
tap_counter/ViewController.swift
Outdated
| // Dispose of any resources that can be recreated. | ||
| } | ||
|
|
||
| @IBOutlet weak var tapCounter: UILabel!; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to define all IBOutlets at the beginning. My usual file structure is
import ...
class ClassName: ParentClass(es) {
// MARK: Constants
// MARK: Outlets
// MARK: Properties
// MARK: Views
// MARK: Init
// MARK: Actions
// MARK: Helpers
}
// MARK: Extensions
extension ClassName {
...
}
// MARK: Delegates
extension ClassName: SomeDelegate {
...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, here is a VERY good article about inline docs http://nshipster.com/swift-documentation/. It is a bit long, I need you to learn the
MARK / TODO / FIXME
section and actively use it. You can skip everything else there for now.
|
Also, about In general, all branches should start with a verb in base form. For example, this one could be Same goes to commit messages. In general, it will replicate branch name, so |
…d link them to tap handlers
|
lgtm 👏 |

First ios project