Skip to content

Conversation

@mmalykov
Copy link
Collaborator

First ios project

Discard #582

:i
@AliceAponasko
Copy link
Member

AliceAponasko commented Sep 11, 2016

unspecified

Left - how it should be, right - yours
Navigation bar should not be gray
There is no Undo button in design
Navigation bar says Counter
Label color is black
Tap button is capitalized, not all caps

// Dispose of any resources that can be recreated.
}

@IBOutlet weak var tapCounter: UILabel!;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to define all IBOutlets at the beginning. My usual file structure is

import ...

class ClassName: ParentClass(es) {

    // MARK: Constants

    // MARK: Outlets

    // MARK: Properties

    // MARK: Views

    // MARK: Init

    // MARK: Actions

    // MARK: Helpers

}

// MARK: Extensions

extension ClassName {
...
}

// MARK: Delegates

extension ClassName: SomeDelegate {
...
}

Copy link
Member

@AliceAponasko AliceAponasko Sep 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, here is a VERY good article about inline docs http://nshipster.com/swift-documentation/. It is a bit long, I need you to learn the

MARK / TODO / FIXME

section and actively use it. You can skip everything else there for now.

@AliceAponasko
Copy link
Member

Also, about git branch naming and comments conventions.

In general, all branches should start with a verb in base form. For example, this one could be add-tap-counter. Usually you would use verbs like add, fix, refactor.

Same goes to commit messages. In general, it will replicate branch name, so Add tap counter.
Some exceptions could be initial commits when you could just say Initial commit.
If you need to explain your commit, do it in Present Simple. For example, Initial commit. Add storyboard, view controller, and tap counter.

@AliceAponasko
Copy link
Member

lgtm 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants