Skip to content

Use cache_file instead of get_file#138

Open
rsmekala wants to merge 5 commits intoJuniper:2019.2from
rsmekala:cache_files
Open

Use cache_file instead of get_file#138
rsmekala wants to merge 5 commits intoJuniper:2019.2from
rsmekala:cache_files

Conversation

@rsmekala
Copy link

@rsmekala rsmekala commented Sep 11, 2019 •
edited
Loading

What does this PR do?

Replace get_file with cache_file. It gives us the following advantages

  1. It is only copied if it already not cached.
  2. It allows us to preserve the file extensions.
  3. No onus of creating a temporary location.

Testing

No

@rsmekala rsmekala requested a review from vnitinv September 11, 2019 14:42
@rsmekala rsmekala changed the title Use cache_file instead of get_file WIP: Use cache_file instead of get_file Sep 11, 2019
@rsmekala rsmekala changed the title WIP: Use cache_file instead of get_file Use cache_file instead of get_file Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vnitinv vnitinv Awaiting requested review from vnitinv

Assignees

No one assigned

Labels

Priority: High

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rsmekala