Open
Conversation
dsetia
reviewed
Oct 19, 2016
| function check_dev() | ||
| { | ||
| interface=$1 | ||
| arr=$(ifconfig | awk '{print $1}') |
Contributor
There was a problem hiding this comment.
Are you sure? I don't see any issue with running ifconfig as non-root user.
Author
There was a problem hiding this comment.
/sbin was not in ubuntu user PATH when I opened this PR. It is now on /etc/environment in the install I have access to. However I do not know if something has modified this file on this system and I do not have access to a vanilla install.
There was a problem hiding this comment.
This is true. The install Guides should add the export PATH=${PATH}:/sbin as a recommendation for the user's environment (typically "stack")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ifconfig is in sbin which is not in the path for lambda users.