Skip to content

remove Enum to optimize the performance #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
songzhw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove Enum to optimize the performance #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions library/src/main/java/com/jungly/gridpasswordview/GridPasswordView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import android.os.Build;
import android.os.Bundle;
import android.os.Parcelable;
import android.support.annotation.IntDef;
import android.text.Editable;
import android.text.InputType;
import android.text.TextUtils;
Expand All @@ -26,6 +27,9 @@

import com.jungly.gridpasswordview.imebugfixer.ImeDelBugFixedEditText;

import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;

/**
* ●
*
Expand Down Expand Up @@ -58,6 +62,15 @@ public class GridPasswordView extends LinearLayout implements PasswordView {
private OnPasswordChangedListener mListener;
private PasswordTransformationMethod mTransformationMethod;

public static final int PWD_TYPE_NUMBER = 0;
public static final int PWD_TYPE_TEXT = 1;
public static final int PWD_TYPE_TEXTVISIBLE = 2;
public static final int PWD_TYPE_TEXTWEB = 3;

@IntDef({PWD_TYPE_NUMBER, PWD_TYPE_TEXT, PWD_TYPE_TEXTVISIBLE, PWD_TYPE_TEXTWEB})
@Retention(RetentionPolicy.SOURCE)
public @interface PasswordType{}

public GridPasswordView(Context context) {
super(context);
initViews(context);
Expand Down Expand Up @@ -394,20 +407,20 @@ public void setOnPasswordChangedListener(OnPasswordChangedListener listener) {
}

@Override
public void setPasswordType(PasswordType passwordType) {
public void setPasswordType(@PasswordType int passwordType) {
boolean visible = getPassWordVisibility();
int inputType = InputType.TYPE_CLASS_NUMBER | InputType.TYPE_NUMBER_VARIATION_PASSWORD;
switch (passwordType) {

case TEXT:
case PWD_TYPE_TEXT:
inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_PASSWORD;
break;

case TEXTVISIBLE:
case PWD_TYPE_TEXTVISIBLE:
inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD;
break;

case TEXTWEB:
case PWD_TYPE_TEXTWEB:
inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_WEB_PASSWORD;
break;
}
Expand Down
12 changes: 0 additions & 12 deletions library/src/main/java/com/jungly/gridpasswordview/PasswordType.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion library/src/main/java/com/jungly/gridpasswordview/PasswordView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ interface PasswordView {

void setOnPasswordChangedListener(GridPasswordView.OnPasswordChangedListener listener);

void setPasswordType(PasswordType passwordType);
void setPasswordType(@GridPasswordView.PasswordType int passwordType);
}