Skip to content

Conversation

@MaxenceGollier
Copy link
Collaborator

@dpo, in ExactPenalty.jl I defined L2PenalizedProblem <: AbstractRegularizedNLPModel
I will make an update RegularizedOptimization.jl, so that the solvers constructors call hess_op(reg_nlp, xk) at the start.
I will then dispatch a different hess_op(::L2PenalizedProblem) where I can give whatever I want.

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.12%. Comparing base (85de184) to head (5001b10).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #81       +/-   ##
===========================================
- Coverage   99.18%   77.12%   -22.07%     
===========================================
  Files          11       19        +8     
  Lines         369      459       +90     
===========================================
- Hits          366      354       -12     
- Misses          3      105      +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ManualNLPModels = "0.2"
MLDatasets = "^0.7.4"
NLPModels = "0.16, 0.17, 0.18, 0.19, 0.20, 0.21"
NLPModelsModifiers = "0.7.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those seem to be only required for the tests?!

@MaxenceGollier
Copy link
Collaborator Author

Yes, I added them in the [extras] section and not the [deps].
I am not sure however whether it is good practice or not to add packages from [extras] in the [compat] section... let me know.

@MaxenceGollier MaxenceGollier merged commit 2550cfd into JuliaSmoothOptimizers:main Feb 2, 2026
11 of 14 checks passed
@MaxenceGollier MaxenceGollier deleted the hess_op branch February 2, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants