feat(api): javascript api for custom ui building#3303
Draft
feat(api): javascript api for custom ui building#3303
Conversation
Member
|
We could factor out the inline definition of create_actions_for(client, {get_state, set_state}) -> PlutoActionsand Editor.js would call it with: create_actions_for(client, {get_state: () => this.state.notebook(), set_state: this.setStatePromise}) |
Member
And it would:
|
Fixes a bug where the serialization creates an invalid toml. This results in spammy logs in the pluto extension
c10a17a to
2344c1b
Compare
Replace brittle string matching with proper TOML parser for cell metadata. This makes the parser more robust and extensible, supporting all TOML data types (booleans, numbers, strings, arrays, etc.) instead of hardcoded patterns. Changes: - Add @iarna/toml dependency for TOML parsing/serialization - Refactor parseCellMetadata() to use TOML.parse() - Refactor serializeCellMetadata() to use TOML.stringify() - Fix merge conflicts in test/test_fs.js 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a bunch of utilities extracted from Editor.jl (thank you claude) that allow for easy embedding of Pluto in other web applications.
Try this Pull Request!
Open Julia and type: