👆 Jump-to-definition on click without Ctrl/Cmd in static export#2452
Merged
👆 Jump-to-definition on click without Ctrl/Cmd in static export#2452
Conversation
Contributor
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="disable-ui-jump-to-definition-without-ctrl")
julia> using Plutothen open a notebook, and add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a static HTML export, you can now click on underlined global variables to jump to its definition. Before this PR, you had to hold Ctrl/Cmd while clicking. After this PR, Ctrl/Cmd is only required in editing mode. (#2449 would help make this clear.)
Same as #2450, but for HTML instead of PDF. (We can't use the same mechanism because codemirror intercepts the
clickevent and calls.preventDefault(). On the PDF, just using the<a>tag already works, because codemirror is not running when viewing the PDF.)The tooltip is not changed (
Ctrl+Click to jump to the definition of hello_world.), but holding down Ctrl while clicking simply has no effect, so it's still correct 😅