Skip to content

Conversation

@oschulz
Copy link
Collaborator

@oschulz oschulz commented Apr 27, 2025

with_logabsdet_jacobian(String, 4.9) returned NoLogAbsDetJacobian{DataType, Float64}(), but should return NoLogAbsDetJacobian{Type{String}, Float64}().

Also improves getjacobian utility in package test code.

@oschulz oschulz requested a review from devmotion April 27, 2025 06:01
@codecov
Copy link

codecov bot commented Apr 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (974119a) to head (8bb9cfa).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   97.59%   97.75%   +0.16%     
==========================================
  Files           5        5              
  Lines          83       89       +6     
==========================================
+ Hits           81       87       +6     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oschulz oschulz force-pushed the fix-noladj branch 3 times, most recently from 757234a to 66cecde Compare April 27, 2025 16:39
@oschulz
Copy link
Collaborator Author

oschulz commented Apr 27, 2025

Ok, tests look good now.

@oschulz oschulz merged commit 8bb9cfa into master Apr 27, 2025
10 checks passed
@oschulz
Copy link
Collaborator Author

oschulz commented Apr 27, 2025

Thanks @devmotion .

@oschulz oschulz deleted the fix-noladj branch April 27, 2025 19:39
@oschulz
Copy link
Collaborator Author

oschulz commented May 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants