Open
Conversation
Member
|
Yeah I meant to refactor the mesh type... Although I would love to make the mesh type more minimal, but then just add metadata for textures to it ;) |
Contributor
Author
|
Yeah, agreed that a simple mesh type with a wrapper for metadata sounds like a great idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was requested over on discourse (ref: https://discourse.julialang.org/t/how-to-load-urdf-files-with-dae-models-into-meshcat/19509/3 ), and I realized that I had a branch implementing a DAE loader just lying around.
I'm not actually sure we'd want to merge this, as it adds a new binary dependency (libxml for LightXML.jl) and it only handles a small subset of what .dae can represent. It really seems like we need a richer mesh type, with support for multiple meshes and textures to represent the .dae contents more faithfully.