Conversation
The obj spec define the statement *vt* as : vt u v w With *u* being the only one required. The current writer only handled case with u and v defined.
The current write only outputs `f v1 v2 v3` However, the obj spec says that f should also reference texture vertices index and vertex normal index in the format `f v1/vt1/vn1 v2/vt2/vn2 v3/vt3/vn3` Furthermore, the spec allow leaving the texture vertices spot empty if there is only vertex normal with the format `f v1//vn1 v2//vn2 v3//vn3`. Both vt and vn are optional if there is no vertex data. Software like Blender and ThreeJs does not load the texture vertices from a MeshIO.jl exported obj.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 74.82% 75.16% +0.33%
==========================================
Files 10 10
Lines 735 745 +10
==========================================
+ Hits 550 560 +10
Misses 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the OBJ exporter to be closer to the OBJ specification, allowing greater compatibility with other software.
Key changes:
v/vt/vn, addressing issue loading with software like Blender and ThreeJs