[WIP] Expanding the work on augmentations in a tutorial#81
Open
[WIP] Expanding the work on augmentations in a tutorial#81
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
theogf
changed the title
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
Author
|
Oh it looks like the new manifest format is not appreciated? |
st--
reviewed
Dec 1, 2021
src/expected_loglik.jl
Outdated
| fs = √2 * std.(q_f) .* xs' .+ mean.(q_f) | ||
| lls = loglikelihood.(lik.(fs), y) | ||
| return sum((1 / √π) * lls * ws) | ||
| return (1 / √π) * mapreduce(dot, +, eachrow(lls), ws) |
Member
There was a problem hiding this comment.
Suggested change
| return (1 / √π) * mapreduce(dot, +, eachrow(lls), ws) | |
| return mapreduce(dot, +, eachrow(lls), ws) / √π |
But also, at this point it's getting really hard to glance at the code and understand what's going on.... what do you think of adding a comment to explaining that?
Member
|
How about sticking to julia 1.6 for the docs in this PR, and we can sort out the upgrade separately ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new tutorial similar to the classification one using augmentation as in AGP.jl.
It shows both the solution with and without hyperparameters optimization.
I still need to give a brief explanation on how the augmentation works but things are working well otherwise