Replace astype by idiomatic convert/broadcast. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rework internals so that we can call truncating intrinsics from the language instead of relying on codegen.
Member
Author
|
To keep things incremental, I'll merge this an open an issue about the truncating behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rework internals so that we can call truncating intrinsics from the language instead of relying on codegen.
One unfortunate difference with Julia this exposes is how conversions are truncating, while Julia throws
InexactErrors and expects one to useunsafe_trunc. I guess we should require usingtrunc.(T, arr)instead? But then what to do with the non-truncating versions (broadcastandconvert), given that we don't have an exception mechanism yet... It also seems hard to have exceptions on conversions when we apply them to tiles.