Open
Conversation
Collaborator
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
=======================================
Coverage 61.82% 61.82%
=======================================
Files 124 124
Lines 3790 3790
=======================================
Hits 2343 2343
Misses 1447 1447 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…s some zed auto-formatting.
benedict-96
commented
Mar 24, 2026
| GeometricBase = "0.11, 0.12" | ||
| GeometricEquations = "0.20" | ||
| GeometricSolutions = "=0.5.9" | ||
| GeometricSolutions = "0.5" |
Collaborator
Author
There was a problem hiding this comment.
This is 0.5 again now (as it should be).
benedict-96
commented
Mar 24, 2026
| using Distances | ||
| using GeometricBase | ||
| using GeometricSolutions: GeometricSolution, EnsembleSolution, DataSeries, StateVariable | ||
| using GeometricSolutions: GeometricSolution, EnsembleSolution, DataSeries, StateVariable, TimeSeries |
Collaborator
Author
There was a problem hiding this comment.
Also importing TimeSeries now.
benedict-96
commented
Mar 24, 2026
| function DataLoader(solution::GeometricSolution{T, T2, TT, NT}, suppress_info = false; kwargs...) where | ||
| {T <: Number, | ||
| T2 <: Number, | ||
| TT <: TimeSeries{T2}, |
Collaborator
Author
There was a problem hiding this comment.
Note that TimeSeries appears before DataSeries in the type parameters now. See JuliaGNI/GeometricSolutions.jl@843cd43.
Member
|
Is it expected that docs are failing at the moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... but had to set GeometricSolutions to 0.5.9 temporarilly.