Skip to content

Conversation

@andreasnoack
Copy link
Contributor

It is not used. FFTW is available under GPL, so the removal would make it easier to use this package in some projects.

@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.27%. Comparing base (2c52b3b) to head (2f7db77).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files           8        8           
  Lines        1459     1459           
=======================================
  Hits         1390     1390           
  Misses         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wheeheee
Copy link
Member

wheeheee commented Jan 5, 2026

Should instead be in [extras] and [targets] I guess, those perf benchmarks still use them.

@devmotion
Copy link

How are the scripts in /perf/ supposed to be run? It seems they are only run locally? I would suggest adding an environment (Project.toml) in the /perf/ directory for benchmark specific dependencies. With the recent [sources] feature of Pkg in Julia >= 1.11, one can also easily refer to and automatically instantiate the package in the parent directory when running Pkg.instantiate() in the /perf/ directory.

@gummif
Copy link
Member

gummif commented Jan 20, 2026

Thanks, I think this is fine for now.

@gummif gummif merged commit 6d382a1 into JuliaDSP:master Jan 20, 2026
5 checks passed
@devmotion
Copy link

Oh, great, thank you! Can you make a new release with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants