fix follow_path for objects with start_pos#496
Open
ArbitRandomUser wants to merge 2 commits intoJuliaAnimators:mainfrom
Open
fix follow_path for objects with start_pos#496ArbitRandomUser wants to merge 2 commits intoJuliaAnimators:mainfrom
ArbitRandomUser wants to merge 2 commits intoJuliaAnimators:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 77.74% 77.24% -0.51%
==========================================
Files 38 38
Lines 1991 2070 +79
==========================================
+ Hits 1548 1599 +51
- Misses 443 471 +28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you are contributing to
Javis.jl, please make sure you are able to check off each item on this list:CHANGELOG.mdwith whatever changes/features I added with this PR?Project.toml+ set an upper bound of the dependency (if applicable)?testdirectory (if applicable)?Link to relevant issue(s)
Closes #
#491
How did you address these issues with this PR? What methods did you use?
the points along which the objects should follow should have object.start_pos subtracted from them.