Add mouse coordinates display in live viewer#326
Open
codejaeger wants to merge 1 commit intoJuliaAnimators:mainfrom
Open
Add mouse coordinates display in live viewer#326codejaeger wants to merge 1 commit intoJuliaAnimators:mainfrom
codejaeger wants to merge 1 commit intoJuliaAnimators:mainfrom
Conversation
f5651ff to
4056efd
Compare
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 96.17% 96.18%
=======================================
Files 21 21
Lines 1151 1154 +3
=======================================
+ Hits 1107 1110 +3
Misses 44 44
Continue to review full report at Codecov.
|
Member
|
Looks great!
|
4056efd to
7120fa5
Compare
Contributor
Author
|
@Wikunia thanks for the review, I made the changes. |
Member
|
Thanks we had a look at this yesterday and we would like to make it a bit clearer with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you are contributing to
Javis.jl, please make sure you are able to check off each item on this list:CHANGELOG.mdwith whatever changes/features I added with this PR?Project.toml+ set an upper bound of the dependency (if applicable)?testdirectory (if applicable)?Demo
Link to relevant issue(s)
Closes #177
How did you address these issues with this PR? What methods did you use?
Added the mouse coordinates into a
Gtklabel. There were 2 ways to do this.Gtk.EventBox(then add the canvas to it) and enable thePOINTER_MOTIONevent in the event box. Then connect a callback to update the coordinates.Gtk.Canvasand add a callback for the update.References:-