Append old swapchains to the end of the old swapchains list#14
Open
charles-juicelabs wants to merge 1 commit intomain-juicefrom
Open
Append old swapchains to the end of the old swapchains list#14charles-juicelabs wants to merge 1 commit intomain-juicefrom
charles-juicelabs wants to merge 1 commit intomain-juicefrom
Conversation
Previously this code updated the front of the list to point to the latest old swapchain, dangling any other swapchains in that list. Any old swapchains weren't all destroyed in prune_old_swapchains() are then leaked. Fixed by updating the pswap pointer until it reaches the end of the list and then inserting the latest old swapchain there.
charles-juicelabs
requested review from
canadacow,
dave-juicelabs,
liam-juicelabs,
nebJL and
ramon-juicelabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this code updated the front of the list to point to the latest old swapchain, dangling any other swapchains in that list. Any old swapchains weren't all destroyed in
prune_old_swapchains()are then leaked.Fixed by updating the
pswappointer until it reaches the end of the list and then inserting the latest old swapchain there.